test: use ES6 in test-debugger-client.js #10183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implements ES6 const and let instead var in test-debugger-client.js
nodejs-github-bot
added
dont-land-on-v7.x
test
cjihrig
approved these changes
Dec 9, 2016
italoacasas
approved these changes
Dec 9, 2016
thefourtheye
approved these changes
Dec 9, 2016
|
@benjamingr looks like the CI didn't start .. |
|
Hmm @nodejs/build what did I do wrong?
…On Mon, Dec 12, 2016 at 4:18 PM, Adrián Estrada ***@***.***> wrote:
@benjamingr <https://github.com/benjamingr> looks like the CI didn't
start ..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10183 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABQSzbXuRl1MAODtYwsqxUwJTiF4ENSqks5rHVe8gaJpZM4LIGtF>
.
|
|
The CI is green, for some reason, Github does not show the output on this one. |
|
It's just that POST_STATUS_TO_PR hasn't been checked |
|
Landed 5607228 Thanks for the contribution Adrian. |
italoacasas
pushed a commit
that referenced
this pull request
Dec 12, 2016
implements ES6 const and let instead var in test-debugger-client.js PR-URL: #10183 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Fishrock123
pushed a commit
that referenced
this pull request
Dec 13, 2016
implements ES6 const and let instead var in test-debugger-client.js PR-URL: #10183 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Merged
|
This is not landing cleanly on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
implements ES6 const and let instead of var in test-debugger-client.js