test: add ES6 and improve test-fs-truncate #10167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use const and let for variables replace assert.equal with assert.strictEqual
cjihrig
approved these changes
Dec 7, 2016
jasnell
approved these changes
Dec 7, 2016
italoacasas
approved these changes
Dec 7, 2016
|
Landed a8e8708 Thanks for the contribution Adrian. |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 13, 2016
- use const and let for variables - replace assert.equal with assert.strictEqual PR-URL: #10167 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 16, 2017
- use const and let for variables - replace assert.equal with assert.strictEqual PR-URL: #10167 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
- use const and let for variables - replace assert.equal with assert.strictEqual PR-URL: #10167 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
- use const and let for variables - replace assert.equal with assert.strictEqual PR-URL: #10167 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Italo A. Casas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
use const and let for variables
replace assert.equal with assert.strictEqual