Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: throw a consistent range error for length > kMaxLength #10152

Closed
wants to merge 1 commit into from
Closed

buffer: throw a consistent range error for length > kMaxLength #10152

wants to merge 1 commit into from
+49 −26

Commits on Dec 13, 2016

  1. buffer: consistent error for length > kMaxLength 

    - Always return the same error message(hopefully more informative)
  for buffer length > kMaxLength and avoid getting into V8 C++ land
  for unnecessary checks.
- Use accurate RegExp(reusable as `common.bufferMaxSizeMsg`)
  in tests for this error.
- Separate related tests from test-buffer-alloc.
    @joyeecheung
    joyeecheung committed Dec 13, 2016
    Configuration menu
    Copy the full SHA
    ec0450e View commit details
    Browse the repository at this point in the history