-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code and learn pr change #10004
code and learn pr change #10004
Conversation
Please see the commit message guidelines here. |
@CodeTheInternet May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines. |
@CodeTheInternet Looks great! Thank you 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI ok except for ARM failure that looks like: #10073 Should be good to go. Will land. |
@CodeTheInternet for the next time, you had an extra dot in the commit message. You should either have the header line, followed by a blank line, followed by a description of the change OR just the header line. I'll remove the line with the dot while landing. |
Landed as 7b4c598 |
PR-URL: #10004 Reviewed-by: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #10004 Reviewed-by: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#10004 Reviewed-by: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#10004 Reviewed-by: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #10004 Reviewed-by: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #10004 Reviewed-by: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #10004 Reviewed-by: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
strictEqual change for parallel test