Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code and learn pr change #10004

Closed
wants to merge 1 commit into from
Closed

code and learn pr change #10004

wants to merge 1 commit into from

Conversation

CodeTheInternet
Copy link
Contributor

strictEqual change for parallel test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex
Copy link
Contributor

mscdex commented Dec 1, 2016

Please see the commit message guidelines here.

@imyller
Copy link
Member

imyller commented Dec 1, 2016

@CodeTheInternet May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines.

@mscdex mscdex added the process Issues and PRs related to the process subsystem. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@CodeTheInternet
Copy link
Contributor Author

@mscdex / @imyller : new commit message added

@imyller
Copy link
Member

imyller commented Dec 1, 2016

@CodeTheInternet Looks great! Thank you 👍

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Dec 5, 2016

@mhdawson
Copy link
Member

mhdawson commented Dec 5, 2016

CI ok except for ARM failure that looks like: #10073

Should be good to go. Will land.

@mhdawson mhdawson self-assigned this Dec 5, 2016
@mhdawson
Copy link
Member

mhdawson commented Dec 5, 2016

@CodeTheInternet for the next time, you had an extra dot in the commit message. You should either have the header line, followed by a blank line, followed by a description of the change OR just the header line. I'll remove the line with the dot while landing.

@mhdawson mhdawson closed this Dec 5, 2016
@mhdawson
Copy link
Member

mhdawson commented Dec 5, 2016

Landed as 7b4c598

mhdawson pushed a commit that referenced this pull request Dec 5, 2016
PR-URL: #10004
Reviewed-by: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
PR-URL: #10004
Reviewed-by: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
PR-URL: nodejs#10004
Reviewed-by: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
PR-URL: nodejs#10004
Reviewed-by: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
PR-URL: #10004
Reviewed-by: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
PR-URL: #10004
Reviewed-by: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
PR-URL: #10004
Reviewed-by: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants