Revert "path: resolve normalize drive letter to lower case" #100
Conversation
|
The commit log should explain why it reverts f6e5740, i.e. why the change in that commit is wrong. |
|
@piscisaureus Can you take a look? |
This reverts commit f6e5740. Changing drive letters to lowercase violates the principle of least surprise. Other functions that do this should get fixed too. Conflicts: lib/path.js
|
I'm not sure how much of the backstory is should include. I've added a short rationale for now. |
|
Thanks, @seishun. @piscisaureus PTAL. If this was discussed somewhere (which I believe it was), can you add a link? |
|
@seishun do the tests enforce this behaviour or do we need a new explicit test to lock it in place? |
|
@rvagg the tests are already case-sensitive, I don't think they could do any better. By the way, the test still fails with this change due to path.join() changing the case of the drive letter (see nodejs/node-v0.x-archive#7031) due to the path.normalize() change mentioned in node-forward/node#20. Should I go ahead and submit a PR fixing that? |
|
Hello! I am pleased to see your valuable contribution to this project. Would you Questions:
Please provide the answers in an ordered list like this:
Note that I am just a bot with a limited human-reply parsing abilities, In case of success I will say: In case of validation problem I will say: Truly yours, Responsibilities
|
This reverts commit f6e5740. Changing drive letters to lowercase violates the principle of least surprise. Other functions that do this should get fixed too. Conflicts: lib/path.js PR-URL: #100 Reviewed-By: Bert Belder <[email protected]>
Changing drive letters to lowercase violates the principle of least surprise. PR-URL: nodejs/node#100
In general path functions don't change the case of a path. Making an exception for windows drive letters violates the principle of least surprise. Changing the drive letter case has caused a lot of issues, including nodejs#7031, nodejs#7806 and lots of bikeshedding about whether uppercase is the right case or lowercase. This effectively reverts nodejs/node-v0.x-archive@a05f973 PR-URL: nodejs/node#100
In general path functions don't change the case of a path. Making an exception for windows drive letters violates the principle of least surprise. Changing the drive letter case has caused a lot of issues, including nodejs#7031, nodejs#7806 and lots of bikeshedding about whether uppercase is the right case or lowercase. This effectively reverts nodejs/node-v0.x-archive@a05f973 PR-URL: nodejs/node#100
This fixes realpath, but test-fs-realpath still fails due to a different issue. Looking into it.
See #17.