Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated variable name in comment #9001

Closed
fhinkel opened this issue Oct 10, 2016 · 2 comments
Closed

Outdated variable name in comment #9001

fhinkel opened this issue Oct 10, 2016 · 2 comments
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. good first issue Issues that are suitable for first-time contributors.

Comments

@fhinkel
Copy link
Member

fhinkel commented Oct 10, 2016

In node.cc:EnvSetter(), a comment mentions rval. But there's no variable of that name.
@fhinkel fhinkel added the good first issue Issues that are suitable for first-time contributors. label Oct 10, 2016
@mscdex mscdex added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 10, 2016
@reza-ryte-club
Copy link

reza-ryte-club commented Oct 11, 2016 •
edited
Loading

Do you mean this lines ?

// Whether it worked or not, always return rval.
      info.GetReturnValue().Set(value);

@gibfahn
Copy link
Member

gibfahn commented Oct 11, 2016

Yep, looks like https://github.com/nodejs/node/blob/master/src/node.cc#L2714

@maasencioh maasencioh mentioned this issue Oct 11, 2016
Closed
1 task
maasencioh added a commit to maasencioh/node that referenced this issue Oct 11, 2016
@maasencioh
src: fix typo rval to value
2153f66 
rval never existed, it was added as that in 077f9d7

Fixes: nodejs#9001
jasnell pushed a commit that referenced this issue Oct 12, 2016
@maasencioh @jasnell
src: fix typo rval to value
e175188 
rval never existed, it was added as that in 077f9d7

Fixes: #9001
PR-URL: #9023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this issue Nov 11, 2016
@maasencioh
src: fix typo rval to value
0e37a6a 
rval never existed, it was added as that in 077f9d7

Fixes: #9001
PR-URL: #9023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this issue Nov 11, 2016
@maasencioh
src: fix typo rval to value
f669a08 
rval never existed, it was added as that in 077f9d7

Fixes: #9001
PR-URL: #9023
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
@aliscco aliscco mentioned this issue Dec 1, 2023
Open
@leonardoadame leonardoadame mentioned this issue Dec 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: fix typo rval to value maasencioh/node
4 participants
@mscdex @fhinkel @reza-ryte-club @gibfahn