util.inspect generates different output in Node minor update

[maxrimue]

• Version: v6.4.0
• Platform: Darwin 15.6.0 Darwin Kernel Version 15.6.0: Thu Jun 23 18:25:34 PDT 2016; root:xnu-3248.60.10~1/RELEASE_X86_64 x86_64
• Subsystem: util/utilities

Since the update from Node.js v6.3 to Node.js v6.4, util.inspect generates a different output for the same object. This broke our tests and I'm not 100% sure if this is intended to happen.

Take this object:

{ desc: 'A command with no name',
  builder: [Function],
  handler: [Function] }

Then, running util.inspect on it:
Node v6.3:

'{ desc: \'A command with no name\',\n  builder: [ [Function: Function] ],\n  handler: [ [Function: Function] ] }'

Node v6.4:

'{ desc: \'A command with no name\',\r\n  builder: [ [Function: Function] ],\r\n  handler: [ [Function: Function] ] }'

Thanks

[yorkie]

See:

• repl,util: insert carriage returns in output fce4b98
• v6.4.0 proposal v6.4.0 Proposal #8070

This is the correct behavior :-)

[maxrimue]

@yorkie Oh I see, thanks!

[addaleax]

The tests for [email protected] through [email protected] are failing with Node v6.4.0, and I think the citgm runs should have caught that… @thealphanerd any idea?

[MylesBorins]

@addaleax yargs passed citgm

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/352/nodes=fedora22/testReport/%28root%29/citgm/yargs_v4_8_1/

we can dig into why

[addaleax]

I’ll try to take a look at that

[bengl]

Looks like yargs' tests fail on 6.4.0 when process.stdout.isTTY is true.

e.g.

$ npm t
// fail
$ npm t > result.out
$ cat result.out
// success

It makes sense, then, that this wasn't caught by citgm.

[addaleax]

@bengl Yup, I can confirm that… see yargs/yargs#597 for an attempt to fix this on yargs’ side