-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
undocumented console.timeEnd() change in 6.x #6452
Comments
Care to open a documentation PR? |
I agree it should be documented even though the way things worked prior to Assigning to myself. |
I'd be happy to. I'm not certain of the appropriate format for documenting API changes. Is there an example in the docs you could point me to? |
This is a really good read: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md Make sure you look at the suggested Git commit log message. Also, here is a randomly picked |
Fix landed in #6454 |
_Description_
On node < 6 you could call timeEnd() multiple times for the same label to receive the current elapsed time. This no longer works in node v6.
This is a side effect of this pull request #3562, which fixed timers being leaked. This change completely makes sense, but it also removes (probably unintended) functionality. Should this change be in the documentation?
_Example_
output on node v5.9.1
output on node v6.0.0
The text was updated successfully, but these errors were encountered: