Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intl 1.50 => £1.5, not £1.50 #6260

Closed
ghost opened this issue Apr 18, 2016 · 7 comments
Closed

Intl 1.50 => £1.5, not £1.50 #6260

ghost opened this issue Apr 18, 2016 · 7 comments
Assignees
Labels
i18n-api Issues and PRs related to the i18n implementation.

Comments

@ghost
Copy link

ghost commented Apr 18, 2016

  • Version: v4.4.3
  • Platform: Darwin 14.5.0 Darwin Kernel Version 14.5.0: Mon Jan 11 18:48:35 PST 2016; root:xnu-2782.50.2~1/RELEASE_X86_64 x86_64
  • Subsystem:
> new Intl.NumberFormat("en-GB", { style: "currency", currency: "GBP" }).format(1.50);
'£1.5'
@mscdex mscdex added the i18n-api Issues and PRs related to the i18n implementation. label Apr 18, 2016
@mscdex
Copy link
Contributor

mscdex commented Apr 18, 2016

/cc @nodejs/intl

@ChALkeR
Copy link
Member

ChALkeR commented Apr 18, 2016

This is fixed in 5.x, btw.

@ChALkeR ChALkeR added the v4.x label Apr 18, 2016
@srl295 srl295 self-assigned this Apr 18, 2016
@srl295
Copy link
Member

srl295 commented Apr 18, 2016

@willnwhite is this with full ICU data or not? try npm install full-icu in your project and follow its instructions

@ghost
Copy link
Author

ghost commented Apr 19, 2016

@srl295 I've now done that and it's the same.

$ node --icu-data-dir=node_modules/full-icu
> new Intl.NumberFormat("en-GB", { style: "currency", currency: "GBP" }).format(1.50)
'£1.5'

@srl295
Copy link
Member

srl295 commented Apr 19, 2016

Will, thanks.

On Mon, Apr 18, 2016 at 11:31 PM, Will White [email protected]
wrote:

@srl295 https://github.com/srl295 I've now done that and it's the same.

$ node --icu-data-dir=node_modules/full-icu

var i10nGBP = new Intl.NumberFormat("en-GB", { style: "currency", currency: "GBP" })
undefined
i10nGBP.format(1.50)
'£1.5'


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6260 (comment)

@targos
Copy link
Member

targos commented Apr 19, 2016

#6275

@targos
Copy link
Member

targos commented Apr 20, 2016

The fix landed on ˋv4.x-staging`

@targos targos closed this as completed Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Development

No branches or pull requests

4 participants