Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 5.7.1 path.normalize broken #5585

Closed
be-dcodeit opened this issue Mar 7, 2016 · 2 comments
Closed

Node 5.7.1 path.normalize broken #5585

be-dcodeit opened this issue Mar 7, 2016 · 2 comments
Labels
confirmed-bug Issues with confirmed bugs. path Issues and PRs related to the path subsystem.

Comments

@be-dcodeit
Copy link

The following sample works fine in node v5.1.0 but is broken in node v5.7.1:

path.normalize("/a/b/c/../../../x/y/z")

Correct (node v5.1.0): /x/y/z
Broken (node v5.7.1): /a/x/y/z

Note this works fine if the first path contains more than 1 character (e.g. "/aa/b/c/../../../x/y/z")

@targos targos added the path Issues and PRs related to the path subsystem. label Mar 7, 2016
@silverwind silverwind added the confirmed-bug Issues with confirmed bugs. label Mar 7, 2016
@silverwind
Copy link
Contributor

cc: @mscdex

MylesBorins pushed a commit that referenced this issue Mar 7, 2016
Fixes a regression introduced by
b212be0.

path.normalize(''/a/b/c/../../../x/y/z'') should return '/x/y/z'.

Fixes: #5585
PR-URL: #5589
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Brian White <[email protected]>
@MylesBorins
Copy link
Contributor

I've added this commit to v5.7.2-proposal

Fishrock123 pushed a commit that referenced this issue Mar 8, 2016
Fixes a regression introduced by
b212be0.

path.normalize(''/a/b/c/../../../x/y/z'') should return '/x/y/z'.

Fixes: #5585
PR-URL: #5589
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Brian White <[email protected]>
Fishrock123 pushed a commit that referenced this issue Mar 8, 2016
Fixes a regression introduced by
b212be0.

path.normalize(''/a/b/c/../../../x/y/z'') should return '/x/y/z'.

Fixes: #5585
PR-URL: #5589
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Brian White <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed-bug Issues with confirmed bugs. path Issues and PRs related to the path subsystem.
Projects
None yet
Development

No branches or pull requests

4 participants