-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url.parse result differences in 5.7.x to 5.6.x #5393
Labels
confirmed-bug
Issues with confirmed bugs.
url
Issues and PRs related to the legacy built-in url module.
Milestone
Comments
/cc @mscdex |
MylesBorins
added
the
url
Issues and PRs related to the legacy built-in url module.
label
Feb 23, 2016
No, though we did have a large |
mscdex
added a commit
to mscdex/io.js
that referenced
this issue
Feb 23, 2016
4 tasks
rvagg
pushed a commit
that referenced
this issue
Feb 28, 2016
Fixes: #5393 PR-URL: #5394 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
confirmed-bug
Issues with confirmed bugs.
url
Issues and PRs related to the legacy built-in url module.
v5.7.0
I updated to Node 5.7.0 today, which results in my Cordova build breaking due to a change in the output of
url.parse
.In Node 5.5.0 the output of parsing
https://*
was the following:However this changed when updating to 5.7.0:
The
pathname
beingnull
now broke the Cordova CLI library. Was this change intended to be breaking?The text was updated successfully, but these errors were encountered: