Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang build error for v22.0.0 #52675

Closed
jhheider opened this issue Apr 24, 2024 · 2 comments · Fixed by #52676
Closed

clang build error for v22.0.0 #52675

jhheider opened this issue Apr 24, 2024 · 2 comments · Fixed by #52676
Labels
build Issues and PRs related to build files or the CI. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Comments

@jhheider
Copy link

jhheider commented Apr 24, 2024 •
edited by VoltrexKeyva
Loading

Version

v22.0.0

Platform

Linux d738e45a1dcc 6.6.22-linuxkit #1 SMP Fri Mar 29 12:21:27 UTC 2024 aarch64 GNU/Linux

Subsystem

v8

What steps will reproduce the bug?

Attempting to build with clang (tried 15 and 18) both result in:

$ clang++ -o /home/builder/actions-runner/_work/pantry/pantry/builds/nodejs.org-22.0.0/out/Release/obj.target/v8_base_without_compiler/deps/v8/src/wasm/wasm-external-refs.o ../deps/v8/src/wasm/wasm-external-refs.cc '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DICU_NO_USER_DATA_OVERRIDE' '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64' '-D__STDC_FORMAT_MACROS' '-DV8_TARGET_ARCH_ARM64' '-DV8_HAVE_TARGET_OS' '-DV8_TARGET_OS_LINUX' '-DV8_EMBEDDER_STRING="-node.10"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_ENABLE_PRIVATE_MAPPING_FORK_OPTIMIZATION' '-DOBJECT_PRINT' '-DV8_INTL_SUPPORT' '-DV8_ATOMIC_OBJECT_FIELD_WRITES' '-DV8_ENABLE_LAZY_SOURCE_POSITIONS' '-DV8_USE_SIPHASH' '-DV8_SHARED_RO_HEAP' '-DNDEBUG' '-DV8_WIN64_UNWINDING_INFO' '-DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH' '-DV8_USE_ZLIB' '-DV8_ENABLE_SPARKPLUG' '-DV8_ENABLE_MAGLEV' '-DV8_ENABLE_TURBOFAN' '-DV8_ENABLE_WEBASSEMBLY' '-DV8_ENABLE_JAVASCRIPT_PROMISE_HOOKS' '-DV8_ENABLE_CONTINUATION_PRESERVED_EMBEDDER_DATA' '-DV8_ALLOCATION_FOLDING' '-DV8_ALLOCATION_SITE_TRACKING' '-DV8_ADVANCED_BIGINT_ALGORITHMS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I/opt/zlib.net/v1.3.1/include -I/opt/openssl.org/v1.1.1w/include -I../deps/v8 -I../deps/v8/include -I/home/builder/actions-runner/_work/pantry/pantry/builds/nodejs.org-22.0.0/out/Release/obj/gen/inspector-generated-output-root -I../deps/v8/third_party/inspector_protocol -I/home/builder/actions-runner/_work/pantry/pantry/builds/nodejs.org-22.0.0/out/Release/obj/gen -I/home/builder/actions-runner/_work/pantry/pantry/builds/nodejs.org-22.0.0/out/Release/obj/gen/generate-bytecode-output-root -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common -I../deps/v8/third_party/zlib -I../deps/v8/third_party/zlib/google -I../deps/v8/third_party/abseil-cpp -I../deps/v8/third_party/fp16/src/include  -pthread -Wno-unused-parameter -Wno-return-type -flax-vector-conversions -Wno-invalid-offsetof -fno-strict-aliasing -O3 -fno-omit-frame-pointer -fdata-sections -ffunction-sections -O3 -fno-rtti -fno-exceptions -std=gnu++17 -MMD -MF /home/builder/actions-runner/_work/pantry/pantry/builds/nodejs.org-22.0.0/out/Release/.deps//home/builder/actions-runner/_work/pantry/pantry/builds/nodejs.org-22.0.0/out/Release/obj.target/v8_base_without_compiler/deps/v8/src/wasm/wasm-external-refs.o.d.raw   -c
../deps/v8/src/wasm/wasm-disassembler.cc:525:17: error: no member named 'setprecision' in namespace 'std'
  525 |       o << std::setprecision(std::numeric_limits<float>::max_digits10) << f;
      |            ~~~~~^

this is fixed upstream in v8/v8@500de8b (specifcially: #include <iomanip>)

How often does it reproduce? Is there a required condition?

every time.

What is the expected behavior? Why is that the expected behavior?

successful compilation. injecting the header fixes it: see pkgxdev/pantry@943cfc3

What do you see instead?

the above compilation error

Additional information

updating the dep from upstream should resolve it.
@jhheider jhheider mentioned this issue Apr 24, 2024
Merged
@RedYetiDev
Copy link
Member

@nodejs/v8
@nodejs/build

@RedYetiDev RedYetiDev added build Issues and PRs related to build files or the CI. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Apr 24, 2024
@richardlau richardlau mentioned this issue Apr 24, 2024
Merged
@richardlau
Copy link
Member

this is fixed upstream in v8/v8@500de8b (specifcially: #include <iomanip>)

Backport PR: #52676

nodejs-github-bot pushed a commit that referenced this issue Apr 26, 2024
@richardlau
deps: V8: cherry-pick 500de8bd371b
40ef9d5 
Original commit message:

    [gcc] Fix gcc / bazel build

    Add <iomanip> includes to fix gcc/blaze builds. Also ignore a dangling
    pointer warning introduced in newer gcc, since it has false positives
    on some uses of scope classes.

    Change-Id: Ib86a2437ffc34b5497a5b8619013d6d5b4ea30fe
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5380192
    Auto-Submit: Leszek Swirski <[email protected]>
    Reviewed-by: Adam Klein <[email protected]>
    Reviewed-by: Michael Achenbach <[email protected]>
    Commit-Queue: Michael Achenbach <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#92977}

Refs: v8/v8@500de8b
PR-URL: #52676
Fixes: #52675
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
aduh95 pushed a commit that referenced this issue Apr 29, 2024
@richardlau @aduh95
deps: V8: cherry-pick 500de8bd371b
27a5f94 
Original commit message:

    [gcc] Fix gcc / bazel build

    Add <iomanip> includes to fix gcc/blaze builds. Also ignore a dangling
    pointer warning introduced in newer gcc, since it has false positives
    on some uses of scope classes.

    Change-Id: Ib86a2437ffc34b5497a5b8619013d6d5b4ea30fe
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5380192
    Auto-Submit: Leszek Swirski <[email protected]>
    Reviewed-by: Adam Klein <[email protected]>
    Reviewed-by: Michael Achenbach <[email protected]>
    Commit-Queue: Michael Achenbach <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#92977}

Refs: v8/v8@500de8b
PR-URL: #52676
Fixes: #52675
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
marco-ippolito pushed a commit that referenced this issue May 23, 2024
@richardlau @marco-ippolito
deps: V8: cherry-pick 500de8bd371b
e3ad05d 
Original commit message:

    [gcc] Fix gcc / bazel build

    Add <iomanip> includes to fix gcc/blaze builds. Also ignore a dangling
    pointer warning introduced in newer gcc, since it has false positives
    on some uses of scope classes.

    Change-Id: Ib86a2437ffc34b5497a5b8619013d6d5b4ea30fe
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5380192
    Auto-Submit: Leszek Swirski <[email protected]>
    Reviewed-by: Adam Klein <[email protected]>
    Reviewed-by: Michael Achenbach <[email protected]>
    Commit-Queue: Michael Achenbach <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#92977}

Refs: v8/v8@500de8b
PR-URL: #52676
Fixes: #52675
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
EliphazBouye pushed a commit to EliphazBouye/node that referenced this issue Jun 20, 2024
@richardlau @EliphazBouye
deps: V8: cherry-pick 500de8bd371b
0829e2f 
Original commit message:

    [gcc] Fix gcc / bazel build

    Add <iomanip> includes to fix gcc/blaze builds. Also ignore a dangling
    pointer warning introduced in newer gcc, since it has false positives
    on some uses of scope classes.

    Change-Id: Ib86a2437ffc34b5497a5b8619013d6d5b4ea30fe
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5380192
    Auto-Submit: Leszek Swirski <[email protected]>
    Reviewed-by: Adam Klein <[email protected]>
    Reviewed-by: Michael Achenbach <[email protected]>
    Commit-Queue: Michael Achenbach <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#92977}

Refs: v8/v8@500de8b
PR-URL: nodejs#52676
Fixes: nodejs#52675
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this issue Jun 22, 2024
@richardlau @bmeck
deps: V8: cherry-pick 500de8bd371b
d380103 
Original commit message:

    [gcc] Fix gcc / bazel build

    Add <iomanip> includes to fix gcc/blaze builds. Also ignore a dangling
    pointer warning introduced in newer gcc, since it has false positives
    on some uses of scope classes.

    Change-Id: Ib86a2437ffc34b5497a5b8619013d6d5b4ea30fe
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5380192
    Auto-Submit: Leszek Swirski <[email protected]>
    Reviewed-by: Adam Klein <[email protected]>
    Reviewed-by: Michael Achenbach <[email protected]>
    Commit-Queue: Michael Achenbach <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#92977}

Refs: v8/v8@500de8b
PR-URL: nodejs#52676
Fixes: nodejs#52675
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: V8: cherry-pick 500de8bd371b richardlau/node-1
3 participants
@richardlau @jhheider @RedYetiDev