Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test pummel/test-stream2-basic.js failing since v4.2.0 #5257

Closed
tallskog opened this issue Feb 16, 2016 · 3 comments
Closed

test pummel/test-stream2-basic.js failing since v4.2.0 #5257

tallskog opened this issue Feb 16, 2016 · 3 comments
Labels
stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.

Comments

@tallskog
Copy link

Test seems to be failing since version 4.2.0, is it still a valid test case?

./node test/pummel/test-stream2-basic.js
# a most basic test
# pipe
# unpipe
# unpipe
# unpipe
# unpipe
# unpipe
# unpipe
# unpipe
# unpipe
# unpipe
# multipipe
# multi-unpipe
# multi-unpipe
# multi-unpipe
# multi-unpipe
# multi-unpipe
# multi-unpipe
# multi-unpipe
# multi-unpipe
# multi-unpipe
# back pressure respected
w1.emit("close")
w2 write [ 'two' ] 0
w3 write [ 'two' ] 1
w2 drain
w2 write [ 'three' ] 1

assert.js:89
  throw new assert.AssertionError({
  ^
AssertionError: 1 == 0
    at Readable.w2.write (node-js/test/pummel/test-stream2-basic.js:336:12)
    at Readable.ondata (_stream_readable.js:528:20)
    at emitOne (events.js:82:20)
    at Readable.emit (events.js:169:7)
    at Readable.read (_stream_readable.js:360:10)
    at flow (_stream_readable.js:743:26)
    at Readable.<anonymous> (_stream_readable.js:601:7)
    at emitNone (events.js:67:13)
    at Readable.emit (events.js:166:7)
    at null._onTimeout (node-js/test/pummel/test-stream2-basic.js:347:10)
@ChALkeR ChALkeR added stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. labels Feb 16, 2016
@Trott
Copy link
Member

Trott commented Feb 16, 2016

That is one of four tests I'm aware of in test/pummel that are currently broken:

  • test-fs-watch-file
  • test-http-upload-timeout
  • test-keep-alive
  • test-stream2-basic

@tallskog
Copy link
Author

Is there a publicly visible CI system (like jenkins) available somewhere where to check the status of tests? Would be nice to know if test is expected to fail or is there something wrong with my own build ;)

I have fixed (on our own CI) test-fs-watch-file by adding call to common.refreshTmpDir and test-http-upload-timeout by increasing the socket timeout (our testing happens if fairly slow MIPS environment).

@Trott
Copy link
Member

Trott commented Feb 17, 2016

@tallskog The CI system is usually publicly available, but it is closed off at the moment for security reasons. You can follow #5194 to find out when it is resolved and the CI is made public again.

Access to CI would not help you in this case, however, because the pummel tests are not run on CI.

I don't know the history on that and therefore I don't know if that is likely to change or not if the four tests are fixed.

However, I would encourage you to submit a pull request for the fix to test-fs-watch-file as I and others are very interested in getting all the tests working again.

/cc @nodejs/testing

MylesBorins pushed a commit that referenced this issue Apr 19, 2016
In 6899094 (#2325),
the conditions for increasing `readableState.awaitDrain` when
writing to a piping destination returns false were changed so
that they could not actually be met, effectively leaving
`readableState.awaitDrain` with a constant value of 0.

This patch changes the conditions to testing whether the
stream for which `.write()` returned false is still a piping
destination, which was likely the intention of the original
patch.

Fixes: #5820
Fixes: #5257
PR-URL: #6023
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Apr 20, 2016
In 6899094 (#2325),
the conditions for increasing `readableState.awaitDrain` when
writing to a piping destination returns false were changed so
that they could not actually be met, effectively leaving
`readableState.awaitDrain` with a constant value of 0.

This patch changes the conditions to testing whether the
stream for which `.write()` returned false is still a piping
destination, which was likely the intention of the original
patch.

Fixes: #5820
Fixes: #5257
PR-URL: #6023
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Apr 20, 2016
In 6899094 (#2325),
the conditions for increasing `readableState.awaitDrain` when
writing to a piping destination returns false were changed so
that they could not actually be met, effectively leaving
`readableState.awaitDrain` with a constant value of 0.

This patch changes the conditions to testing whether the
stream for which `.write()` returned false is still a piping
destination, which was likely the intention of the original
patch.

Fixes: #5820
Fixes: #5257
PR-URL: #6023
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this issue Apr 26, 2016
In 6899094 (#2325),
the conditions for increasing `readableState.awaitDrain` when
writing to a piping destination returns false were changed so
that they could not actually be met, effectively leaving
`readableState.awaitDrain` with a constant value of 0.

This patch changes the conditions to testing whether the
stream for which `.write()` returned false is still a piping
destination, which was likely the intention of the original
patch.

Fixes: #5820
Fixes: #5257
PR-URL: #6023
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Apr 30, 2016
In 6899094 (#2325),
the conditions for increasing `readableState.awaitDrain` when
writing to a piping destination returns false were changed so
that they could not actually be met, effectively leaving
`readableState.awaitDrain` with a constant value of 0.

This patch changes the conditions to testing whether the
stream for which `.write()` returned false is still a piping
destination, which was likely the intention of the original
patch.

Fixes: #5820
Fixes: #5257
PR-URL: #6023
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue May 6, 2016
In 6899094 (#2325),
the conditions for increasing `readableState.awaitDrain` when
writing to a piping destination returns false were changed so
that they could not actually be met, effectively leaving
`readableState.awaitDrain` with a constant value of 0.

This patch changes the conditions to testing whether the
stream for which `.write()` returned false is still a piping
destination, which was likely the intention of the original
patch.

Fixes: #5820
Fixes: #5257
PR-URL: #6023
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue May 18, 2016
In 6899094 (#2325),
the conditions for increasing `readableState.awaitDrain` when
writing to a piping destination returns false were changed so
that they could not actually be met, effectively leaving
`readableState.awaitDrain` with a constant value of 0.

This patch changes the conditions to testing whether the
stream for which `.write()` returned false is still a piping
destination, which was likely the intention of the original
patch.

Fixes: #5820
Fixes: #5257
PR-URL: #6023
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

3 participants