Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: v1.0.3 #500

Closed
rvagg opened this issue Jan 18, 2015 · 21 comments
Closed

Release proposal: v1.0.3 #500

rvagg opened this issue Jan 18, 2015 · 21 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@rvagg
Copy link
Member

rvagg commented Jan 18, 2015

* 1b1cd1c - build: shorten configurate script print on stdout (Roman Reiss)
* d566ded - deps: fix V8 debugger bugs (Jay Jaeho Lee)
* 6f36630 - doc: fix util.isBuffer examples (Thomas Jensen)
* 3abfb56 - benchmark: fix tcp bench after internal api change (Yosuke Furukawa)
* 50177fb - benchmark: stop v8 benchmark clobbering RegExp (Ben Noordhuis)
* 1952219 - deps: make node-gyp work again on windows (Bert Belder)
* a28de9b - deps: make node-gyp fetch tarballs from iojs.org (Ben Noordhuis)
* 9dc8f59 - deps: upgrade npm to 2.2.0 (Forrest L Norvell)
* e8ad773 - src: remove --noharmony_classes again (Ben Noordhuis)
* 334020e - deps: fix v8 build on FreeBSD (Fedor Indutny)
* 5e7ebc7 - deps: upgrade v8 to 4.1.0.7 (Ben Noordhuis)
* ea7750b - benchmark: add filter option for benchmark (Yosuke Furukawa)
* 4764eef - doc: fixed punctuation (Brenard Cubacub)
* de224d6 - configure: remove --ninja switch (Ben Noordhuis)
* 48774ec0 - configure: print warning for old compilers (Ben Noordhuis)
* daf9562 - doc: change to iojs from node in the usage message (Jongyeol Choi)
* 3fde649 - build: add tools/gflags to PYTHONPATH (Shigeki Ohtsu)
* 8b22df1 - doc: add python-gflags LICENSE block (Shigeki Ohtsu)
* 6242229 - tools: add python-gflags module (Shigeki Ohtsu)

The main items being V8 upgrade to 4.1 (not breaking) and npm to 2.2.0. There is a nightly at https://iojs.org/download/nightly/v1.0.3-nightly2015011850177fb13c/ that's without the top 4 in the above list of commits (close enough).

Proposal is to press the release button this time tomorrow, bringing in any additional minor commits added to v1.x.

@jonathanong
Copy link
Contributor

aside: can we get "new features from the v8 upgrade" added to changelogs (at least end-user-facing ones, not necessary changelog.md)? something like:

  • deps: upgrade v8 to 4.1.0.7
    • adds ES6 class (though this would be false in this situation)

would be nice for those of us who care more about new ES features.

another aside: can we get a release history w/ human-readable change logs on the site?

@rvagg
Copy link
Member Author

rvagg commented Jan 19, 2015

I've been trying to add a "notable changes" section to the changelog that's more human-readable, it should probably be the responsibility of the person cutting the release (not always me) to come up with that. In the case of the V8 upgrade I don't believe any user-facing features have been added so that's about all we can say about it.

@Fishrock123
Copy link
Contributor

@jonathanong hopefully part of nodejs/iojs.org#68

@Fishrock123
Copy link
Contributor

+1 because the node-gyp patches

@bnoordhuis
Copy link
Member

We should back-port the patch for https://code.google.com/p/v8/issues/detail?id=3820 unless someone from the V8 team beats us to it. Unfortunately, it doesn't apply cleanly.

It's not a regression, however, so I don't think it needs to be a release blocker.

@silverwind
Copy link
Contributor

How about a section with known issues in the changelog? The armv6 one is pretty serious, I'd say.

@piscisaureus
Copy link
Contributor

Yes, go for it.

@rvagg
Copy link
Member Author

rvagg commented Jan 20, 2015

* 9419e1f - src: fix inconsistency between a check and error (toastynerd)
* 03ee4d8 - fs: add error code on null byte paths (cjihrig)
* e2558f0 - net: fix error details in connect() (cjihrig)
* 4af5746 - win,build: remove duplicate definition (Bert Belder)
* e8d0850 - win: bring back xp/2k3 support (Bert Belder)
* 4dd22b9 - cluster: avoid race enabling debugger in worker (Timothy J Fontaine)
* 6b91c78 - test: reland changes from 11c1bae (Ben Noordhuis)
* 992a1e7 - test: debug-signal-cluster should not be racey (Timothy J Fontaine)
* cdf0df1 - test: temporarily back out changes from 11c1bae (Ben Noordhuis)
* 1ea607c - test: move sequential/test-debug-port-from-cmdline (Ben Noordhuis)
* 2f33e00 - test: fix test-debug-port-from-cmdline.js (Julien Gilli)
* b7365c1 - repl: make REPL support multiline template literals (Xiaowei Li)
* 2253d30 - build: remove unused variable (Johan Bergström)
* ab04a43 - doc: add optional sudo to make install in README (Glen Keane)

CI for release kicked off @ https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/97/

@jbergstroem
Copy link
Member

:shipit:

@rvagg
Copy link
Member Author

rvagg commented Jan 20, 2015

Nightlies building: https://jenkins-iojs.nodesource.com/job/iojs+release+nightly/63/ will come out at https://iojs.org/download/nightly/ as 201501209419e1fb69

(This process is being a bit slow today because I'm doing this while in an endless series of meetings! We need to deputise more people to be able to push releases so I'm not a blocker.)

@rvagg
Copy link
Member Author

rvagg commented Jan 20, 2015

Quick tests look on binaries look good

Building releases @ https://jenkins-iojs.nodesource.com/job/iojs+release/19/

I've also switched to tagging as just "v1.0.3" rather than "v1.0.3-release" as per @piscisaureus' suggestion

@rvagg
Copy link
Member Author

rvagg commented Jan 20, 2015

Done, https://iojs.org/dist/v1.0.3/

@iojs/website could someone upgrade the site to say 1.0.3 please? I don't have time unfortunately.

@ralphtheninja
Copy link
Contributor

🤘

Fishrock123 added a commit to nodejs/iojs.org that referenced this issue Jan 20, 2015
@Fishrock123
Copy link
Contributor

Website updated.

@mgol
Copy link
Contributor

mgol commented Jan 20, 2015

https://iojs.org/es6.html still mentions io.js 1.0.2 and in two places v8
3.31 (abandoned & since updated to 4.1).

Michał Gołębiowski

@Fishrock123
Copy link
Contributor

@mzgol we caught those shortly after, thanks though.

@rvagg
Copy link
Member Author

rvagg commented Jan 20, 2015

rock on

@rvagg rvagg closed this as completed Jan 20, 2015
@mgol
Copy link
Contributor

mgol commented Jan 20, 2015

I wrote this on Twitter but I'll repeat here: there's a mistake in the release drscription at https://github.com/iojs/io.js/blob/v1.x/CHANGELOG.md#2015-01-20-version-103-rvagg:

"The 3.31 branch is now not tracking towards a stable release.”

That’s not true; 3.30 will go to Chrome 40 soon; 3.31 is abandoned.

@jbergstroem
Copy link
Member

@mzgol The wording could perhaps be a bit more specific, but that's what @rvagg just said. 3.31 is not for stable, regardless version.

@rvagg
Copy link
Member Author

rvagg commented Jan 20, 2015

@mzgol "now not tracking ...", what's the inaccuracy here exactly?

@mgol
Copy link
Contributor

mgol commented Jan 20, 2015

@rvagg @jbergstroem sorry all, I didn't see the not 😓

Fishrock123 added a commit to nodejs/iojs.org that referenced this issue Feb 8, 2015
@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

10 participants