Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stepping through a three lines of code crashes node 4.2.6 #4917

Closed
weinand opened this issue Jan 27, 2016 · 8 comments
Closed

stepping through a three lines of code crashes node 4.2.6 #4917

weinand opened this issue Jan 27, 2016 · 8 comments

Comments

@weinand
Copy link

weinand commented Jan 27, 2016

launch this snippet test.js:

var obj = {};
console.log(obj);
console.log(obj);

with node --debug-brk test.js and attach a debugger, e.g. node-inspector or VSCode.

The first step command works fine, the second step crashes node on all platforms.

@bnoordhuis
Copy link
Member

Can you check that the nightly build works? This sounds like #4261 and #4322 (and a few more) which were fixed in #4328.

@weinand
Copy link
Author

weinand commented Jan 27, 2016

@bnoordhuis no, the nightly build still cannot successfully step over the second console.log. The only difference I see on OS X is that I don't get an OS alert for the crashing node application. In node 4.2.6 I got an alert.

@bnoordhuis
Copy link
Member

I cannot reproduce with master, at least not with the built-in debug client (node debug 127.0.0.1:5858). The client does hang after the second step but that's #4651, an unrelated issue. The debuggee prints {} twice, as expected.

@MylesBorins
Copy link
Contributor

This looks like a duplicate of the hug I'm working on with util and debug
contexts. I'll add the issue number when I'm on my computer
On Jan 27, 2016 2:23 PM, "Ben Noordhuis" [email protected] wrote:

I cannot reproduce with master, at least not with the built-in debug
client (node debug 127.0.0.1:5858). The client does hang after the second
step but that's #4651 #4651, an
unrelated issue. The debuggee prints {} twice, as expected.


Reply to this email directly or view it on GitHub
#4917 (comment).

@bnoordhuis
Copy link
Member

As a data point, when I revert commit 25776f3 (the fix from #4328), the debuggee does crash on the second step. Maybe there is more at play but for now my money is on #4328.

@weinand
Copy link
Author

weinand commented Jan 27, 2016

@bnoordhuis yes, the problem doesn't repro with the built-in debug client.

@evanlucas
Copy link
Contributor

I cannot reproduce this on master using node-inspector. Is this still an issue?

@MylesBorins
Copy link
Contributor

I think this was fixed a while back. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants