Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: http.request parameter protocol defaults to http could mention it ignores trailing colon #4712

Closed
kapouer opened this issue Jan 15, 2016 · 0 comments
Closed

doc: http.request parameter protocol defaults to http could mention it ignores trailing colon #4712

kapouer opened this issue Jan 15, 2016 · 0 comments

Comments

@kapouer
Copy link
Contributor

kapouer commented Jan 15, 2016

Because it says

options can be an object or a string. If options is a string, it is automatically parsed with url.parse().
protocol: Protocol to use. Defaults to 'http'.

url.parse() returns a protocol with trailing colons, and this is a little confusing.
cjihrig added a commit to cjihrig/node that referenced this issue Jan 15, 2016
@cjihrig
doc: clarify protocol default in http.request()
d013f00 
The previously listed default of 'http' is incorrect, and
causes an error to be thrown. This commit changes it to the
correct value of 'http:'

Fixes: nodejs#4712
@cjihrig cjihrig mentioned this issue Jan 15, 2016
Closed
jasnell pushed a commit that referenced this issue Jan 15, 2016
@cjihrig @jasnell
doc: clarify protocol default in http.request()
7e1564d 
The previously listed default of 'http' is incorrect, and
causes an error to be thrown. This commit changes it to the
correct value of 'http:'

Fixes: #4712
PR-URL: #4714
Reviewed-By: James M Snell <[email protected]>
evanlucas pushed a commit that referenced this issue Jan 18, 2016
@cjihrig @evanlucas
doc: clarify protocol default in http.request()
dcaf6fd 
The previously listed default of 'http' is incorrect, and
causes an error to be thrown. This commit changes it to the
correct value of 'http:'

Fixes: #4712
PR-URL: #4714
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this issue Jan 19, 2016
@cjihrig
doc: clarify protocol default in http.request()
8c2b65a 
The previously listed default of 'http' is incorrect, and
causes an error to be thrown. This commit changes it to the
correct value of 'http:'

Fixes: #4712
PR-URL: #4714
Reviewed-By: James M Snell <[email protected]>
scovetta pushed a commit to scovetta/node that referenced this issue Apr 2, 2016
@cjihrig
doc: clarify protocol default in http.request()
8f6ab31 
The previously listed default of 'http' is incorrect, and
causes an error to be thrown. This commit changes it to the
correct value of 'http:'

Fixes: nodejs#4712
PR-URL: nodejs#4714
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kapouer