Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade undici to v5.20.0 in v18 and v19 as soon as possible #46713

Closed
mcollina opened this issue Feb 18, 2023 · 5 comments
Closed

Upgrade undici to v5.20.0 in v18 and v19 as soon as possible #46713

mcollina opened this issue Feb 18, 2023 · 5 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@mcollina
Copy link
Member

mcollina commented Feb 18, 2023

Unfortunately in the lastest security release we backported v5.19.1 without the proper wait time to catch any lingering bugs, and two regressions happened that broke fetch() for a lot of users in Node v18.x:

Both of those are already fixed in undici v5.20.0 that I just released.

We should land #46711, release it to v19.x and backport it to v18.x as quickly as possible.

I'm sorry for the additional work for @nodejs/releasers :(.

cc @nodejs/tsc for visibility

@mcollina mcollina changed the title Upgrade undici to v5.20.0 in v18 and v19 asap Upgrade undici to v5.20.0 in v18 and v19 as soon as possible Feb 18, 2023
@mcollina mcollina added the meta Issues and PRs related to the general management of the project. label Feb 18, 2023
@targos
Copy link
Member

targos commented Feb 18, 2023

We could update it along with npm /cc @MylesBorins

@MylesBorins
Copy link
Contributor

I can pick up with the npm fixes. I could try and put together the proposal over the weekend.

@ronag
Copy link
Member

ronag commented Feb 18, 2023

Yea, I missed this as well. Sorry for the inconvenience.

garywu added a commit to AIWrangler/site that referenced this issue Feb 21, 2023
@MylesBorins
Copy link
Contributor

This is fixed

@mcollina
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

4 participants