Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I18n French? #45090

Closed
AugustinMauroy opened this issue Oct 20, 2022 · 7 comments
Closed

I18n French? #45090

AugustinMauroy opened this issue Oct 20, 2022 · 7 comments
Labels
install Issues and PRs related to the installers. windows Issues and PRs related to the Windows platform.

Comments

@AugustinMauroy
Copy link
Contributor

I have seen translation files.
Is it possible to translate?
If yes how? With which modality?

Have a good day
AM
@bnoordhuis
Copy link
Member

I have seen translation files

What files are you referring to?

@Trott
Copy link
Member

Trott commented Oct 21, 2022

I have seen translation files. Is it possible to translate? If yes how? With which modality?

Website pages (excluding API reference): https://github.com/nodejs/nodejs.org/tree/main/locale/fr

API reference: https://crowdin.com/project/nodejs/fr

@AugustinMauroy
Copy link
Contributor Author

EX https://github.com/nodejs/node/blob/main/tools/msvs/msi/i18n/de-de.wxl

@bnoordhuis
Copy link
Member

That's the installer. The node executable itself isn't internationalized and there are no plans to do so. Contributions to the website are of course welcome.

@targos
Copy link
Member

targos commented Oct 21, 2022

I suppose we would also welcome a French translation of the Windows installer.

@targos targos added windows Issues and PRs related to the Windows platform. install Issues and PRs related to the installers. labels Oct 21, 2022
@AugustinMauroy
Copy link
Contributor Author

@targos Yes
But how do I do it?

@bnoordhuis
Copy link
Member

It may be a bit more involved than copying and translating an existing language file because...

...i18n is disabled in the installer. There are a couple of language files but tools/msvs/msi/nodemsi.wixproj only includes en-us.wxl.

Some git spelunking indicates the translations were disabled in 2016 until further notice (#7798) and said notice never came.

Given that in no one (to my knowledge) complained in those six years, we should probably just make it official and remove the last vestiges. I'll open a PR.

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Oct 23, 2022
@bnoordhuis
install: remove unused language files
fcd7e16 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: nodejs#45090
@bnoordhuis bnoordhuis mentioned this issue Oct 23, 2022
Closed
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Oct 23, 2022
@bnoordhuis
installer: remove unused language files
36de209 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: nodejs#45090
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Oct 24, 2022
@bnoordhuis
build: remove unused language files
0fa45f9 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: nodejs#45090
anonrig pushed a commit that referenced this issue Oct 27, 2022
@bnoordhuis @anonrig
build: remove unused language files
9c13e05 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this issue Nov 1, 2022
@bnoordhuis @RafaelGSS
build: remove unused language files
cccc873 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this issue Nov 10, 2022
@bnoordhuis @RafaelGSS
build: remove unused language files
29b9f4f 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
@bnoordhuis @danielleadams
build: remove unused language files
3418072 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
@bnoordhuis @danielleadams
build: remove unused language files
e166dc5 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@bnoordhuis bnoordhuis mentioned this issue Jan 2, 2023
Closed
danielleadams pushed a commit that referenced this issue Jan 3, 2023
@bnoordhuis @danielleadams
build: remove unused language files
8a99221 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
install Issues and PRs related to the installers. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bnoordhuis @Trott @targos @AugustinMauroy