-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate flaky test-watch-mode (no. 3) #44898
Comments
Similar output:
@MoLow Looks like the order within some arrays is non-deterministic. Not sure if that's a bug in the implementation or in the test. |
On vacation, will have to wait unless someone else wants to give it a look |
This issue was observed on Windows on Arm platform too. @tniessen @MoLow @richardlau Would you accept to mark those tests as flaky, waiting for a proper fix? |
That test is failing in a variety of ways on our debian builds too (https://buildd.debian.org/status/package.php?p=nodejs&suite=experimental) |
Created a PR to mark those test-watch-mode as flaky, so it can unlock the current situation. |
IMO they're more than flaky, several times they just hang for a long time. |
Is there a timeout of stuff like this we can set for nodejs tests? Or deletion is the only alternative? |
In theory there is already a timeout for tests, but in the case of that test it didn't work (as usual, take what I say with precautions because it's with the debian build of nodejs) and the whole test suite just hang. |
@richardlau @MoLow Should we delete those tests for now, as they seem to create some difficult problems? I know it's not ideal, but hanging a testsuite and report random failures is really a huge difficulty. |
the timeouts happen in the |
|
@tniessen @MoLow I've opened 2 PRs fixing both |
Refs: #44898 PR-URL: #45586 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: #44898 PR-URL: #45585 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: #44898 PR-URL: #45586 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: #44898 PR-URL: #45585 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
I'm assuming this is fixed since #45585 landed? Please re-open if that proves not to be the case. |
Refs: #44898 PR-URL: #45586 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: #44898 PR-URL: #45585 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: #44898 PR-URL: #45586 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: #44898 PR-URL: #45585 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: #44898 PR-URL: #45586 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: #44898 PR-URL: #45585 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: #44898 PR-URL: #45586 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: #44898 PR-URL: #45585 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: #44898 PR-URL: #45586 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Refs: #44898 PR-URL: #45585 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This test is inside the Build: https://ci.nodejs.org/job/node-test-binary-armv7l/5443/ |
I'm not sure why this CI run failed, but it's not because of the test timeout. |
It failed because of leftover Node.js processes at the end of the test run:
Lines 538 to 543 in 5fa84e8
|
Another failure of
|
PR-URL: #48147 Fixes: #44898 Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #48147 Fixes: #44898 Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#48147 Fixes: nodejs#44898 Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#48147 Fixes: nodejs#44898 Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#48147 Fixes: nodejs#44898 Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#48147 Fixes: nodejs#44898 Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: nodejs#48147 Fixes: nodejs#44898 Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #48147 Backport-PR-URL: #49468 Fixes: #44898 Reviewed-By: Benjamin Gruenbaum <[email protected]>
PR-URL: #48147 Backport-PR-URL: #49468 Fixes: #44898 Reviewed-By: Benjamin Gruenbaum <[email protected]>
This happened again in https://ci.nodejs.org/job/node-test-commit-smartos/55674/nodes=smartos20-64/ Re-opening this. |
Test
test-watch-mode
Platform
Linux x64, FreeBSD
Console output
Build links
Additional information
Refs: #44655
Refs: #44735
Refs: #44805
The text was updated successfully, but these errors were encountered: