Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTS (16.17.0) includes buggy version of npm #44406

Open
alexlamsl opened this issue Aug 26, 2022 · 12 comments
Open

LTS (16.17.0) includes buggy version of npm #44406

alexlamsl opened this issue Aug 26, 2022 · 12 comments
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.

Comments

@alexlamsl
Copy link

Version

v16.17.0

Platform

Microsoft Windows [Version 10.0.14393]

Subsystem

npm

What steps will reproduce the bug?

$ npm config set optional=false
$ git clone https://github.com/mishoo/UglifyJS.git
$ npm install
$ npm test

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

Runs without superflous [...] - : timing config:load:flatten Completed in 3ms spamming every line of log output.

What do you see instead?

$ npm test
npm WARN config optional Use `--omit=optional` to exclude optional dependencies, or
npm WARN config `--include=optional` to include them.
npm WARN config
npm WARN config     Default value does install optional deps unless otherwise omitted.

> [email protected] test
> node test/compress.js && node test/mocha.js

--- annotations.js.] - : timing config:load:flatten Completed in 3ms
    Running test [issue_2629_1] config:load:flatten Completed in 3ms
    Running test [issue_2629_2]
    Running test [issue_2629_3]
    Running test [issue_2629_4]
    Running test [issue_2629_5]
    Running test [issue_2638]
    Running test [issue_2705_1]
    Running test [issue_2705_2]
    Running test [issue_2705_3]
    Running test [issue_2705_4] config:load:flatten Completed in 3ms
    Running test [issue_2705_5]
    Running test [issue_2705_6]
    Running test [issue_3858]
    Running test [inline_pure_call_1]g:load:flatten Completed in 3ms
    Running test [inline_pure_call_2]
    Running test [inline_pure_call_3]
    Running test [inline_pure_call_4]g:load:flatten Completed in 3ms
    Running test [compress_and_output_annotations_enabled]
    Running test [compress_annotations_disabled_output_annotations_enabled]
    Running test [compress_and_output_annotations_disabled]
--- arguments.js
    Running test [replace_index]config:load:flatten Completed in 3ms
    Running test [replace_index_strict]load:flatten Completed in 3ms
    Running test [replace_index_drop_fargs_1]latten Completed in 3ms
    Running test [replace_index_drop_fargs_2]latten Completed in 3ms
    Running test [modified]
    Running test [modified_strict]nfig:load:flatten Completed in 3ms
    Running test [duplicate_argname]ig:load:flatten Completed in 3ms
    Running test [fraction]ming config:load:flatten Completed in 3ms
    Running test [issue_3273]
    Running test [issue_3273_no_call_arg]ad:flatten Completed in 3ms
    Running test [issue_3273_reduce_vars]
    Running test [issue_3273_local_strict]d:flatten Completed in 3ms
    Running test [issue_3273_local_strict_reduce_vars]
    Running test [issue_3273_global_strict]:flatten Completed in 3ms
    Running test [issue_3273_global_strict_reduce_vars]
    Running test [issue_3273_drop_fargs_1]d:flatten Completed in 3ms
    Running test [issue_3273_drop_fargs_2]
    Running test [issue_3282_1] config:load:flatten Completed in 3ms
    Running test [issue_3282_1_passes]
    Running test [issue_3282_2] config:load:flatten Completed in 3ms
    Running test [issue_3282_2_passes]:load:flatten Completed in 3ms
    Running test [issue_3420_1]
    Running test [issue_3420_2] config:load:flatten Completed in 3ms
    Running test [issue_3420_3]
    Running test [issue_3420_4]
    Running test [issue_3420_5] config:load:flatten Completed in 3ms
    Running test [issue_3420_6] config:load:flatten Completed in 3ms
    Running test [issue_3420_7]
    Running test [issue_4200]
    Running test [issue_4291_1] config:load:flatten Completed in 3ms
    Running test [issue_4291_2]
    Running test [issue_4397]ng config:load:flatten Completed in 3ms
    Running test [issue_4410_1]
    Running test [issue_4410_2] config:load:flatten Completed in 3ms
    Running test [issue_4410_3]
    Running test [issue_4432]ng config:load:flatten Completed in 3ms
    Running test [issue_4696]ng config:load:flatten Completed in 3ms
    Running test [issue_4809]
--- arrays.js......] - : timing config:load:flatten Completed in 3ms
    Running test [holes_and_undefined]:load:flatten Completed in 3ms
    Running test [constant_join_1]nfig:load:flatten Completed in 3ms
    Running test [constant_join_2]
    Running test [constant_join_3]
    Running test [for_loop]
    Running test [index] timing config:load:flatten Completed in 3ms
    Running test [length]
    Running test [index_length] config:load:flatten Completed in 3ms
    Running test [constructor_bad]
    Running test [constructor_good]fig:load:flatten Completed in 3ms
    Running test [unsafe_evaluate_modified_binary]n Completed in 3ms
    Running test [unsafe_evaluate_modified_conditional]pleted in 3ms
    Running test [unsafe_evaluate_modified_sequence]Completed in 3ms
--- arrows.js
    Running test [no_funarg]ing config:load:flatten Completed in 3ms
    Running test [single_funarg]
    Running test [multiple_funargs]fig:load:flatten Completed in 3ms
    Running test [destructured_funarg]
    Running test [await_parentheses]ig:load:flatten Completed in 3ms
    Running test [for_parentheses_init]
    Running test [for_parentheses_condition]flatten Completed in 3ms
    Running test [for_parentheses_step]
    Running test [for_assign_parentheses_init]atten Completed in 3ms
    Running test [for_assign_parentheses_condition]
    Running test [for_assign_parentheses_step]atten Completed in 3ms
    Running test [for_declaration_parentheses_init]
    Running test [for_statement_parentheses_init]en Completed in 3ms
    Running test [body_call]ing config:load:flatten Completed in 3ms
    Running test [body_conditional]
    Running test [destructured_object_value]flatten Completed in 3ms
    Running test [function_value]
    Running test [in_value]
    Running test [object_value] config:load:flatten Completed in 3ms
    Running test [object_first_in_value]oad:flatten Completed in 3ms
    Running test [sequence_value]
    Running test [side_effects_value]g:load:flatten Completed in 3ms
    Running test [arrow_property]
    Running test [assign_arrow] config:load:flatten Completed in 3ms
    Running test [binary_arrow]
    Running test [unary_arrow]g config:load:flatten Completed in 3ms
    Running test [trailing_comma]
    Running test [drop_arguments]
    Running test [funarg_arguments]fig:load:flatten Completed in 3ms
    Running test [inline_arguments]
    Running test [var_arguments]config:load:flatten Completed in 3ms
    Running test [negate]
    Running test [inline_this]g config:load:flatten Completed in 3ms
    Running test [dont_inline_this]
    Running test [trim_body]ing config:load:flatten Completed in 3ms
    Running test [collapse_value]onfig:load:flatten Completed in 3ms
    Running test [collapse_property_lambda]
    Running test [drop_return]g config:load:flatten Completed in 3ms
    Running test [drop_value]
    Running test [reduce_iife_1]config:load:flatten Completed in 3ms
    Running test [reduce_iife_2]
    Running test [reduce_iife_3]config:load:flatten Completed in 3ms
    Running test [reduce_lambda_1]
    Running test [reduce_lambda_2]nfig:load:flatten Completed in 3ms
    Running test [single_use_recursive]load:flatten Completed in 3ms
    Running test [issue_4388]
    Running test [issue_4390]ng config:load:flatten Completed in 3ms
    Running test [issue_4401]ng config:load:flatten Completed in 3ms
    Running test [issue_4448]ng config:load:flatten Completed in 3ms
    Running test [issue_4476]
    Running test [issue_4666]ng config:load:flatten Completed in 3ms
    Running test [issue_4685_1] config:load:flatten Completed in 3ms
    Running test [issue_4685_2] config:load:flatten Completed in 3ms
    Running test [issue_4687_1]
    Running test [issue_4687_2] config:load:flatten Completed in 3ms
    Running test [issue_4772]ng config:load:flatten Completed in 3ms
    Running test [issue_5251]
    Running test [issue_5342_1] config:load:flatten Completed in 3ms
    Running test [issue_5342_2] config:load:flatten Completed in 3ms
    Running test [issue_5356]ng config:load:flatten Completed in 3ms
    Running test [issue_5414_1]
    Running test [issue_5414_2] config:load:flatten Completed in 3ms
    Running test [issue_5416_1] config:load:flatten Completed in 3ms
    Running test [issue_5416_2] config:load:flatten Completed in 3ms
    Running test [issue_5416_3]
    Running test [issue_5416_4] config:load:flatten Completed in 3ms
    Running test [issue_5495]ng config:load:flatten Completed in 3ms
--- asm.js
    Running test [asm_mixed]ing config:load:flatten Completed in 3ms
    Running test [asm_toplevel]
    Running test [asm_function_expression]d:flatten Completed in 3ms
    Running test [asm_nested_functions]
    Running test [issue_3636_1]
    Running test [issue_3636_2] config:load:flatten Completed in 3ms
--- assignments.js.] - : timing config:load:flatten Completed in 3ms
    Running test [op_equals_left_local_var]:flatten Completed in 3ms
    Running test [op_equals_right_local_var]
    Running test [op_equals_left_global_var]flatten Completed in 3ms
    Running test [op_equals_right_global_var]
    Running test [increment_decrement_1]
    Running test [increment_decrement_2]oad:flatten Completed in 3ms
    Running test [issue_3375_1] config:load:flatten Completed in 3ms
    Running test [issue_3375_2] config:load:flatten Completed in 3ms
    Running test [issue_3427]
    Running test [issue_3429_1]
    Running test [issue_3429_2] config:load:flatten Completed in 3ms
    Running test [issue_3949_1]
    Running test [issue_3949_2] config:load:flatten Completed in 3ms
    Running test [issue_4521]ng config:load:flatten Completed in 3ms
    Running test [logical_assignments]
    Running test [logical_collapse_vars_1]d:flatten Completed in 3ms
    Running test [logical_collapse_vars_2]
    Running test [logical_collapse_vars_3]d:flatten Completed in 3ms
    Running test [logical_reduce_vars]
    Running test [logical_side_effects]load:flatten Completed in 3ms
    Running test [evaluate_lazy_assignment]:flatten Completed in 3ms
    Running test [issue_4815_1]
    Running test [issue_4815_2] config:load:flatten Completed in 3ms
    Running test [issue_4819]
    Running test [issue_4827_1] config:load:flatten Completed in 3ms
    Running test [issue_4827_2]
    Running test [issue_4827_3] config:load:flatten Completed in 3ms
    Running test [issue_4876]
    Running test [issue_4924_1] config:load:flatten Completed in 3ms
    Running test [issue_4924_2] config:load:flatten Completed in 3ms
--- awaits.js
    Running test [async_arrow]g config:load:flatten Completed in 3ms
    Running test [async_computed]onfig:load:flatten Completed in 3ms
    Running test [async_label]g config:load:flatten Completed in 3ms
    Running test [await_await]g config:load:flatten Completed in 3ms
    Running test [defun_name]ng config:load:flatten Completed in 3ms
    Running test [drop_fname]ng config:load:flatten Completed in 3ms
    Running test [keep_fname]ng config:load:flatten Completed in 3ms
    Running test [nested_await] config:load:flatten Completed in 3ms
    Running test [reduce_single_use_defun]d:flatten Completed in 3ms
    Running test [dont_inline]g config:load:flatten Completed in 3ms
    Running test [dont_inline_nested]g:load:flatten Completed in 3ms
    Running test [inline_await_1]onfig:load:flatten Completed in 3ms
    Running test [inline_await_1_trim]:load:flatten Completed in 3ms
    Running test [inline_await_2]onfig:load:flatten Completed in 3ms
    Running test [inline_await_2_trim]:load:flatten Completed in 3ms
    Running test [inline_await_3]onfig:load:flatten Completed in 3ms
    Running test [inline_await_3_trim]:load:flatten Completed in 3ms
    Running test [inline_await_this]ig:load:flatten Completed in 3ms
    Running test [inline_block] config:load:flatten Completed in 3ms
    Running test [inline_block_async]g:load:flatten Completed in 3ms
    Running test [inline_block_await]g:load:flatten Completed in 3ms
    Running test [inline_block_await_async]:flatten Completed in 3ms
    Running test [inline_block_await_async_return]n Completed in 3ms
    Running test [inline_block_return]:load:flatten Completed in 3ms
    Running test [inline_block_return_async]flatten Completed in 3ms
    Running test [await_then]ng config:load:flatten Completed in 3ms
    Running test [await_unary_1]config:load:flatten Completed in 3ms
    Running test [await_unary_2]config:load:flatten Completed in 3ms
    Running test [await_unary_3]config:load:flatten Completed in 3ms
    Running test [await_void_1] config:load:flatten Completed in 3ms
    Running test [await_void_2] config:load:flatten Completed in 3ms
    Running test [evaluate]ming config:load:flatten Completed in 3ms
    Running test [negate]timing config:load:flatten Completed in 3ms
    Running test [negate_iife]g config:load:flatten Completed in 3ms
    Running test [object_function]nfig:load:flatten Completed in 3ms
    Running test [collapse_vars_1]nfig:load:flatten Completed in 3ms
    Running test [collapse_vars_2]nfig:load:flatten Completed in 3ms
    Running test [collapse_vars_3]nfig:load:flatten Completed in 3ms
    Running test [collapse_funarg_1]ig:load:flatten Completed in 3ms
    Running test [collapse_funarg_2]ig:load:flatten Completed in 3ms
    Running test [collapse_property_lambda]:flatten Completed in 3ms
    Running test [drop_async_1] config:load:flatten Completed in 3ms
    Running test [drop_async_2] config:load:flatten Completed in 3ms
    Running test [drop_return]g config:load:flatten Completed in 3ms
    Running test [functions]ing config:load:flatten Completed in 3ms
    Running test [functions_use_strict]load:flatten Completed in 3ms
    Running test [functions_anonymous]:load:flatten Completed in 3ms
    Running test [functions_inner_var]:load:flatten Completed in 3ms
    Running test [instanceof_lambda]
    Running test [issue_4335_1] config:load:flatten Completed in 3ms
    Running test [issue_4335_2] config:load:flatten Completed in 3ms
    Running test [issue_4337]ng config:load:flatten Completed in 3ms
    Running test [issue_4340]ng config:load:flatten Completed in 3ms
    Running test [call_expression]nfig:load:flatten Completed in 3ms
    Running test [property_access_expression]latten Completed in 3ms
    Running test [reduce_iife_1]config:load:flatten Completed in 3ms
    Running test [reduce_iife_2]config:load:flatten Completed in 3ms
    Running test [reduce_iife_3]config:load:flatten Completed in 3ms
    Running test [issue_4347_1] config:load:flatten Completed in 3ms
    Running test [issue_4347_2] config:load:flatten Completed in 3ms
    Running test [issue_4349_1] config:load:flatten Completed in 3ms
    Running test [issue_4349_2] config:load:flatten Completed in 3ms
    Running test [issue_4349_3] config:load:flatten Completed in 3ms
    Running test [issue_4359]ng config:load:flatten Completed in 3ms
    Running test [issue_4377]ng config:load:flatten Completed in 3ms
    Running test [issue_4406]ng config:load:flatten Completed in 3ms
    Running test [issue_4417]ng config:load:flatten Completed in 3ms
    Running test [issue_4454_1] config:load:flatten Completed in 3ms
    Running test [issue_4454_2] config:load:flatten Completed in 3ms
    Running test [issue_4534]ng config:load:flatten Completed in 3ms
    Running test [issue_4581]ng config:load:flatten Completed in 3ms
    Running test [issue_4595]ng config:load:flatten Completed in 3ms
    Running test [issue_4598]ng config:load:flatten Completed in 3ms
    Running test [issue_4618]ng config:load:flatten Completed in 3ms
    Running test [issue_4717]ng config:load:flatten Completed in 3ms
    Running test [issue_4738_1] config:load:flatten Completed in 3ms
    Running test [issue_4738_2] config:load:flatten Completed in 3ms
    Running test [issue_4738_3] config:load:flatten Completed in 3ms
    Running test [issue_4747]ng config:load:flatten Completed in 3ms
    Running test [issue_4764_1] config:load:flatten Completed in 3ms
    Running test [issue_4764_2] config:load:flatten Completed in 3ms
    Running test [issue_4764_3] config:load:flatten Completed in 3ms
    Running test [issue_4972_1] config:load:flatten Completed in 3ms
    Running test [issue_4972_2] config:load:flatten Completed in 3ms
    Running test [issue_4972_3] config:load:flatten Completed in 3ms
    Running test [issue_4974]ng config:load:flatten Completed in 3ms
    Running test [issue_4975]ng config:load:flatten Completed in 3ms
    Running test [issue_4987]ng config:load:flatten Completed in 3ms
    Running test [issue_5001]ng config:load:flatten Completed in 3ms
    Running test [issue_5019_1] config:load:flatten Completed in 3ms
    Running test [issue_5019_2] config:load:flatten Completed in 3ms
    Running test [issue_5019_3] config:load:flatten Completed in 3ms
    Running test [issue_5023_1] config:load:flatten Completed in 3ms
    Running test [issue_5023_2] config:load:flatten Completed in 3ms
    Running test [issue_5034]ng config:load:flatten Completed in 3ms
    Running test [issue_5070]ng config:load:flatten Completed in 3ms
    Running test [issue_5157_async_function]flatten Completed in 3ms
    Running test [issue_5157_async_iife]oad:flatten Completed in 3ms
    Running test [issue_5157_promise]g:load:flatten Completed in 3ms
    Running test [issue_5159_1] config:load:flatten Completed in 3ms
    Running test [issue_5159_2] config:load:flatten Completed in 3ms
    Running test [issue_5177]ng config:load:flatten Completed in 3ms
    Running test [issue_5250]ng config:load:flatten Completed in 3ms
    Running test [issue_5258_1] config:load:flatten Completed in 3ms
    Running test [issue_5258_2] config:load:flatten Completed in 3ms
    Running test [issue_5298]ng config:load:flatten Completed in 3ms
    Running test [issue_5305_1] config:load:flatten Completed in 3ms
    Running test [issue_5305_2] config:load:flatten Completed in 3ms
    Running test [issue_5305_3] config:load:flatten Completed in 3ms
    Running test [issue_5456]ng config:load:flatten Completed in 3ms
    Running test [issue_5478]ng config:load:flatten Completed in 3ms
    Running test [issue_5493]ng config:load:flatten Completed in 3ms
    Running test [issue_5506]ng config:load:flatten Completed in 3ms
    Running test [issue_5528_1] config:load:flatten Completed in 3ms
    Running test [issue_5528_2] config:load:flatten Completed in 3ms
    Running test [issue_5528_3] config:load:flatten Completed in 3ms
    Running test [issue_5528_4] config:load:flatten Completed in 3ms
--- bigint.js......] - : timing config:load:flatten Completed in 3ms
    Running test [arithmetic]ng config:load:flatten Completed in 3ms
    Running test [minus_dot]ing config:load:flatten Completed in 3ms
    Running test [evaluate]ming config:load:flatten Completed in 3ms
    Running test [Number]
    Running test [issue_4590]ng config:load:flatten Completed in 3ms
    Running test [issue_4801]
--- blocks.js......] - : timing config:load:flatten Completed in 3ms
    Running test [remove_blocks]config:load:flatten Completed in 3ms
    Running test [keep_some_blocks]
--- booleans.js
    Running test [iife_boolean_context]load:flatten Completed in 3ms
    Running test [de_morgan_1a] config:load:flatten Completed in 3ms
    Running test [de_morgan_1b] config:load:flatten Completed in 3ms
    Running test [de_morgan_1c]
    Running test [de_morgan_2a]
    Running test [de_morgan_2b] config:load:flatten Completed in 3ms
    Running test [de_morgan_2c] config:load:flatten Completed in 3ms
    Running test [de_morgan_2d] config:load:flatten Completed in 3ms
    Running test [de_morgan_3a]
    Running test [de_morgan_3b] config:load:flatten Completed in 3ms
    Running test [de_morgan_3c] config:load:flatten Completed in 3ms
    Running test [de_morgan_3d] config:load:flatten Completed in 3ms
    Running test [de_morgan_3e]
    Running test [de_morgan_3f] config:load:flatten Completed in 3ms
    Running test [de_morgan_3g] config:load:flatten Completed in 3ms
    Running test [de_morgan_3h] config:load:flatten Completed in 3ms
    Running test [conditional_chain]ig:load:flatten Completed in 3ms
    Running test [negated_if]
    Running test [concat_truthy]config:load:flatten Completed in 3ms
    Running test [process_returns]
    Running test [issue_3465_1] config:load:flatten Completed in 3ms
    Running test [issue_3465_2]
    Running test [issue_3465_3] config:load:flatten Completed in 3ms
    Running test [issue_2737_2]
    Running test [issue_3658]ng config:load:flatten Completed in 3ms
    Running test [issue_3690]
    Running test [issue_4374]ng config:load:flatten Completed in 3ms
    Running test [issue_5028_1] config:load:flatten Completed in 3ms
    Running test [issue_5028_2]
    Running test [issue_5028_3] config:load:flatten Completed in 3ms
    Running test [issue_5041_1]
    Running test [issue_5041_2] config:load:flatten Completed in 3ms
    Running test [issue_5228]
    Running test [issue_5469]ng config:load:flatten Completed in 3ms
--- classes.js.....] - : timing config:load:flatten Completed in 3ms
    Running test [constructor_1]config:load:flatten Completed in 3ms
    Running test [constructor_2]
    Running test [constructor_3]config:load:flatten Completed in 3ms
    Running test [constructor_4]config:load:flatten Completed in 3ms
    Running test [fields]
    Running test [modifier_as_field_name]ad:flatten Completed in 3ms
    Running test [methods]iming config:load:flatten Completed in 3ms
    Running test [private_methods]nfig:load:flatten Completed in 3ms
    Running test [await] timing config:load:flatten Completed in 3ms
    Running test [yield] timing config:load:flatten Completed in 3ms
    Running test [conditional_parentheses]d:flatten Completed in 3ms
    Running test [class_super]g config:load:flatten Completed in 3ms
    Running test [static_newline_1]fig:load:flatten Completed in 3ms
    Running test [static_newline_2]fig:load:flatten Completed in 3ms
    Running test [static_newline_3]
    Running test [static_newline_4]fig:load:flatten Completed in 3ms
    Running test [static_newline_init]
    Running test [static_init]g config:load:flatten Completed in 3ms
    Running test [static_field_init]
    Running test [static_field_init_strict]:flatten Completed in 3ms
    Running test [static_init_side_effects_1]latten Completed in 3ms
    Running test [static_init_side_effects_1_strict]
    Running test [static_init_side_effects_2]latten Completed in 3ms
    Running test [static_init_side_effects_2_strict]Completed in 3ms
    Running test [block_scoped]
    Running test [retain_declaration]g:load:flatten Completed in 3ms
    Running test [drop_extends]
    Running test [keep_extends_1]onfig:load:flatten Completed in 3ms
    Running test [keep_extends_2]
    Running test [keep_extends_3]onfig:load:flatten Completed in 3ms
    Running test [drop_name]
    Running test [separate_name]config:load:flatten Completed in 3ms
    Running test [static_getter]
    Running test [static_setter]config:load:flatten Completed in 3ms
    Running test [static_side_effects]
    Running test [static_side_effects_strict]latten Completed in 3ms
    Running test [single_use_1]
    Running test [single_use_2] config:load:flatten Completed in 3ms
    Running test [single_use_3]
    Running test [single_use_4] config:load:flatten Completed in 3ms
    Running test [single_use_5]
    Running test [single_use_6] config:load:flatten Completed in 3ms
    Running test [single_use_7] config:load:flatten Completed in 3ms
    Running test [single_use_extends]
    Running test [single_use_extends_non_strict]ten Completed in 3ms
    Running test [collapse_non_strict]
    Running test [collapse_rhs] config:load:flatten Completed in 3ms
    Running test [collapse_rhs_static]
    Running test [inline_non_strict]ig:load:flatten Completed in 3ms
    Running test [self_comparison]nfig:load:flatten Completed in 3ms
    Running test [property_side_effects]oad:flatten Completed in 3ms
    Running test [property_side_effects_static]tten Completed in 3ms
    Running test [unused_await] config:load:flatten Completed in 3ms
    Running test [unused_await_strict]
    Running test [computed_key_side_effects]
    Running test [computed_key_generator]ad:flatten Completed in 3ms
    Running test [keep_fnames]
    Running test [instanceof_lambda]ig:load:flatten Completed in 3ms
    Running test [drop_instanceof]
    Running test [keep_instanceof_1]ig:load:flatten Completed in 3ms
    Running test [keep_instanceof_2]
    Running test [keep_instanceof_3]ig:load:flatten Completed in 3ms
    Running test [issue_805_1]g config:load:flatten Completed in 3ms
    Running test [issue_805_2]g config:load:flatten Completed in 3ms
    Running test [issue_4681]ng config:load:flatten Completed in 3ms
    Running test [issue_4683]
    Running test [issue_4685_1] config:load:flatten Completed in 3ms
    Running test [issue_4685_2]
    Running test [issue_4687_1] config:load:flatten Completed in 3ms
    Running test [issue_4687_2] config:load:flatten Completed in 3ms
    Running test [issue_4705]ng config:load:flatten Completed in 3ms
    Running test [issue_4705_strict]
    Running test [issue_4720]ng config:load:flatten Completed in 3ms
    Running test [issue_4721]
    Running test [issue_4722_1] config:load:flatten Completed in 3ms
    Running test [issue_4722_2]
    Running test [issue_4722_3] config:load:flatten Completed in 3ms
    Running test [issue_4725_1] config:load:flatten Completed in 3ms
    Running test [issue_4725_2] config:load:flatten Completed in 3ms
    Running test [new_target]ng config:load:flatten Completed in 3ms
    Running test [issue_4756]
    Running test [issue_4756_strict]ig:load:flatten Completed in 3ms
    Running test [issue_4821_1]
    Running test [issue_4821_2]
    Running test [issue_4829_1] config:load:flatten Completed in 3ms
    Running test [issue_4829_2] config:load:flatten Completed in 3ms
    Running test [mangle_properties]
    Running test [issue_4848]ng config:load:flatten Completed in 3ms
    Running test [drop_unused_self_reference]latten Completed in 3ms
    Running test [issue_4951_1] config:load:flatten Completed in 3ms
    Running test [issue_4951_2]
    Running test [issue_4962_1] config:load:flatten Completed in 3ms
    Running test [issue_4962_1_strict]
    Running test [issue_4962_1_strict_direct]latten Completed in 3ms
    Running test [issue_4962_2]
    Running test [issue_4962_2_strict]:load:flatten Completed in 3ms
    Running test [issue_4962_2_strict_direct]latten Completed in 3ms
    Running test [issue_4962_2_strict_direct_inline]
    Running test [issue_4982_1] config:load:flatten Completed in 3ms
    Running test [issue_4982_2]
    Running test [issue_4992]ng config:load:flatten Completed in 3ms
    Running test [issue_4996_1] config:load:flatten Completed in 3ms
    Running test [issue_4996_2] config:load:flatten Completed in 3ms
    Running test [issue_5015_1]
    Running test [issue_5015_2] config:load:flatten Completed in 3ms
    Running test [issue_5015_3]
    Running test [issue_5015_4] config:load:flatten Completed in 3ms
    Running test [issue_5053_1]
    Running test [issue_5053_2] config:load:flatten Completed in 3ms
    Running test [issue_5053_3] config:load:flatten Completed in 3ms
    Running test [issue_5053_4]
    Running test [issue_5082_1] config:load:flatten Completed in 3ms
    Running test [issue_5082_1_strict]:load:flatten Completed in 3ms
    Running test [issue_5082_2] config:load:flatten Completed in 3ms
    Running test [issue_5082_2_static]:load:flatten Completed in 3ms
    Running test [issue_5142]
    Running test [issue_5294_1] config:load:flatten Completed in 3ms
    Running test [issue_5294_2]
    Running test [issue_5294_3] config:load:flatten Completed in 3ms
    Running test [issue_5294_4]
    Running test [issue_5322]ng config:load:flatten Completed in 3ms
    Running test [issue_5352]
    Running test [issue_5387]ng config:load:flatten Completed in 3ms
    Running test [issue_5389_1] config:load:flatten Completed in 3ms
    Running test [issue_5389_2]
    Running test [issue_5436]ng config:load:flatten Completed in 3ms
    Running test [issue_5481]ng config:load:flatten Completed in 3ms
    Running test [issue_5489]
    Running test [issue_5489_strict]ig:load:flatten Completed in 3ms
    Running test [issue_5502]
    Running test [issue_5504]ng config:load:flatten Completed in 3ms
    Running test [issue_5512]ng config:load:flatten Completed in 3ms
    Running test [issue_5531_1]
    Running test [issue_5531_2] config:load:flatten Completed in 3ms
    Running test [issue_5531_3] config:load:flatten Completed in 3ms
--- collapse_vars.js - : timing config:load:flatten Completed in 3ms
    Running test [collapse_vars_side_effects_1]tten Completed in 3ms
    Running test [collapse_vars_side_effects_2]tten Completed in 3ms
    Running test [collapse_vars_issue_721]d:flatten Completed in 3ms
    Running test [collapse_vars_properties]
    Running test [collapse_vars_if]
    Running test [collapse_vars_while]
    Running test [collapse_vars_do_while]
    Running test [collapse_vars_do_while_drop_assign]ompleted in 3ms
    Running test [collapse_vars_seq]
    Running test [collapse_vars_throw]:load:flatten Completed in 3ms
    Running test [collapse_vars_switch_1]ad:flatten Completed in 3ms
    Running test [collapse_vars_switch_2]
    Running test [collapse_vars_assignment]
    Running test [collapse_vars_lvalues]
    Running test [collapse_vars_lvalues_drop_assign]Completed in 3ms
    Running test [collapse_vars_misc]
    Running test [collapse_vars_self_reference]
    Running test [collapse_vars_repeated]
    Running test [collapse_vars_closures]ad:flatten Completed in 3ms
    Running test [collapse_vars_unary]
    Running test [collapse_vars_try]
    Running test [collapse_vars_array_1]
    Running test [collapse_vars_array_2]oad:flatten Completed in 3ms
    Running test [collapse_vars_array_3]
    Running test [collapse_vars_object_1]ad:flatten Completed in 3ms
    Running test [collapse_vars_object_2]
    Running test [collapse_vars_object_3]
    Running test [collapse_vars_eval_and_with]atten Completed in 3ms
    Running test [collapse_vars_constants]d:flatten Completed in 3ms
    Running test [collapse_vars_arguments_1]
    Running test [collapse_vars_arguments_2]flatten Completed in 3ms
    Running test [collapse_vars_arguments_3]flatten Completed in 3ms
    Running test [collapse_vars_short_circuit]atten Completed in 3ms
    Running test [collapse_vars_short_circuited_conditions]
    Running test [collapse_vars_regexp]
    Running test [collapse_arg_sequence]oad:flatten Completed in 3ms
    Running test [collapse_for_init]
    Running test [issue_1537]ng config:load:flatten Completed in 3ms
    Running test [issue_1562]
    Running test [issue_1605_1]
    Running test [issue_1605_2]
    Running test [issue_1631_1]
    Running test [issue_1631_2] config:load:flatten Completed in 3ms
    Running test [issue_1631_3]
    Running test [var_side_effects_1]g:load:flatten Completed in 3ms
    Running test [var_side_effects_2]g:load:flatten Completed in 3ms
    Running test [var_side_effects_3]
    Running test [reduce_vars_assign]g:load:flatten Completed in 3ms
    Running test [iife_1]
    Running test [iife_2]
    Running test [var_defs]ming config:load:flatten Completed in 3ms
    Running test [assignment]ng config:load:flatten Completed in 3ms
    Running test [for_init]
    Running test [switch_case_1]
    Running test [switch_case_2]
    Running test [switch_case_3]config:load:flatten Completed in 3ms
    Running test [issue_27]ming config:load:flatten Completed in 3ms
    Running test [modified]
    Running test [issue_1858]ng config:load:flatten Completed in 3ms
    Running test [anonymous_function]
    Running test [side_effects_property]oad:flatten Completed in 3ms
    Running test [undeclared_1]
    Running test [undeclared_2]
    Running test [undeclared_3] config:load:flatten Completed in 3ms
    Running test [undeclared_4]
    Running test [ref_scope]
    Running test [chained_1]
    Running test [chained_2]ing config:load:flatten Completed in 3ms
    Running test [chained_3]
    Running test [chained_4]ing config:load:flatten Completed in 3ms
    Running test [chained_5]
    Running test [boolean_binary_1]fig:load:flatten Completed in 3ms
    Running test [boolean_binary_2]
    Running test [inner_lvalues]config:load:flatten Completed in 3ms
    Running test [double_def_1] config:load:flatten Completed in 3ms
    Running test [double_def_2]
    Running test [toplevel_single_reference]
    Running test [unused_orig]
    Running test [issue_315]ing config:load:flatten Completed in 3ms
    Running test [lvalues_def]g config:load:flatten Completed in 3ms
    Running test [compound_assignment_1]
    Running test [compound_assignment_2]oad:flatten Completed in 3ms
    Running test [compound_assignment_3]
    Running test [compound_assignment_4]oad:flatten Completed in 3ms
    Running test [compound_assignment_5]
    Running test [compound_assignment_6]oad:flatten Completed in 3ms
    Running test [compound_assignment_7]
    Running test [compound_assignment_8]oad:flatten Completed in 3ms
    Running test [issue_2187_1] config:load:flatten Completed in 3ms
    Running test [issue_2187_2]
    Running test [issue_2187_3] config:load:flatten Completed in 3ms
    Running test [issue_2203_1]
    Running test [issue_2203_2] config:load:flatten Completed in 3ms
    Running test [duplicate_argname]
    Running test [issue_2298]ng config:load:flatten Completed in 3ms
    Running test [issue_2313_1] config:load:flatten Completed in 3ms
    Running test [issue_2313_2] config:load:flatten Completed in 3ms
    Running test [issue_2319_1]
    Running test [issue_2319_2] config:load:flatten Completed in 3ms
    Running test [issue_2319_3] config:load:flatten Completed in 3ms
    Running test [issue_2365]ng config:load:flatten Completed in 3ms
    Running test [issue_2364_1] config:load:flatten Completed in 3ms
    Running test [issue_2364_2] config:load:flatten Completed in 3ms
    Running test [issue_2364_3]
    Running test [issue_2364_4] config:load:flatten Completed in 3ms
    Running test [issue_2364_5] config:load:flatten Completed in 3ms
    Running test [issue_2364_6]
    Running test [issue_2364_7] config:load:flatten Completed in 3ms
    Running test [issue_2364_8]
    Running test [issue_2364_9] config:load:flatten Completed in 3ms
    Running test [pure_getters_chain]g:load:flatten Completed in 3ms
    Running test [conditional_1]config:load:flatten Completed in 3ms
    Running test [conditional_2]config:load:flatten Completed in 3ms
    Running test [issue_2425_1]
    Running test [issue_2425_2] config:load:flatten Completed in 3ms
    Running test [issue_2425_3] config:load:flatten Completed in 3ms
    Running test [issue_2437_1]
    Running test [issue_2437_2] config:load:flatten Completed in 3ms
    Running test [issue_2436_1]
    Running test [issue_2436_2]
    Running test [issue_2436_3] config:load:flatten Completed in 3ms
    Running test [issue_2436_4] config:load:flatten Completed in 3ms
    Running test [issue_2436_5]
    Running test [issue_2436_6] config:load:flatten Completed in 3ms
    Running test [issue_2436_7]
    Running test [issue_2436_8] config:load:flatten Completed in 3ms
    Running test [issue_2436_9]
    Running test [issue_2436_10]config:load:flatten Completed in 3ms
    Running test [issue_2436_11]config:load:flatten Completed in 3ms
    Running test [issue_2436_12]
    Running test [issue_2436_13]
    Running test [issue_2436_14]config:load:flatten Completed in 3ms
    Running test [issue_2497]ng config:load:flatten Completed in 3ms
    Running test [issue_2506]
    Running test [issue_2571_1] config:load:flatten Completed in 3ms
    Running test [issue_2571_2]
    Running test [may_throw_1]g config:load:flatten Completed in 3ms
    Running test [may_throw_2]
    Running test [side_effect_free_replacement]tten Completed in 3ms
    Running test [recursive_function_replacement]
    Running test [cascade_conditional]
    Running test [cascade_if_1]
    Running test [cascade_if_2]
    Running test [cascade_return]
    Running test [cascade_switch]
    Running test [cascade_call]
    Running test [replace_all_var]
    Running test [replace_all_var_scope]oad:flatten Completed in 3ms
    Running test [cascade_statement]
    Running test [cascade_forin]
    Running test [unsafe_builtin]onfig:load:flatten Completed in 3ms
    Running test [return_1]ming config:load:flatten Completed in 3ms
    Running test [return_2]ming config:load:flatten Completed in 3ms
    Running test [return_3]ming config:load:flatten Completed in 3ms
    Running test [return_4]ming config:load:flatten Completed in 3ms
    Running test [issue_2858]
    Running test [cond_branch_1]config:load:flatten Completed in 3ms
    Running test [cond_branch_2]config:load:flatten Completed in 3ms
    Running test [cond_branch_switch]g:load:flatten Completed in 3ms
    Running test [issue_2873_1]
    Running test [issue_2873_2] config:load:flatten Completed in 3ms
    Running test [issue_2878]ng config:load:flatten Completed in 3ms
    Running test [issue_2891_1]
    Running test [issue_2891_2] config:load:flatten Completed in 3ms
    Running test [issue_2908]ng config:load:flatten Completed in 3ms
    Running test [issue_2914_1] config:load:flatten Completed in 3ms
    Running test [issue_2914_2] config:load:flatten Completed in 3ms
    Running test [issue_805]ing config:load:flatten Completed in 3ms
    Running test [issue_2931]
    Running test [issue_2954_1]
    Running test [issue_2954_2] config:load:flatten Completed in 3ms
    Running test [issue_2954_3] config:load:flatten Completed in 3ms
    Running test [collapse_rhs_conditional_1]
    Running test [collapse_rhs_conditional_2]latten Completed in 3ms
    Running test [collapse_rhs_lhs_1]g:load:flatten Completed in 3ms
    Running test [collapse_rhs_lhs_2]
    Running test [collapse_rhs_loop]ig:load:flatten Completed in 3ms
    Running test [collapse_rhs_side_effects]
    Running test [collapse_rhs_vardef]:load:flatten Completed in 3ms
    Running test [collapse_rhs_array]g:load:flatten Completed in 3ms
    Running test [collapse_rhs_boolean_1]ad:flatten Completed in 3ms
    Running test [collapse_rhs_boolean_2]
    Running test [collapse_rhs_boolean_3]ad:flatten Completed in 3ms
    Running test [collapse_rhs_function]
    Running test [collapse_rhs_number]:load:flatten Completed in 3ms
    Running test [collapse_rhs_object]:load:flatten Completed in 3ms
    Running test [collapse_rhs_regexp]
    Running test [collapse_rhs_string]:load:flatten Completed in 3ms
    Running test [collapse_rhs_var]fig:load:flatten Completed in 3ms
    Running test [collapse_rhs_this]ig:load:flatten Completed in 3ms
    Running test [collapse_rhs_undefined]ad:flatten Completed in 3ms
    Running test [issue_2974]ng config:load:flatten Completed in 3ms
    Running test [issue_3032]ng config:load:flatten Completed in 3ms
    Running test [issue_3096]
    Running test [issue_3215_1] config:load:flatten Completed in 3ms
    Running test [issue_3215_2]
    Running test [issue_3215_3] config:load:flatten Completed in 3ms
    Running test [issue_3215_4]
    Running test [issue_3238_1] config:load:flatten Completed in 3ms
    Running test [issue_3238_2] config:load:flatten Completed in 3ms
    Running test [issue_3238_3] config:load:flatten Completed in 3ms
    Running test [issue_3238_4] config:load:flatten Completed in 3ms
    Running test [issue_3238_5] config:load:flatten Completed in 3ms
    Running test [issue_3238_6] config:load:flatten Completed in 3ms
    Running test [issue_3247]ng config:load:flatten Completed in 3ms
    Running test [issue_3305]ng config:load:flatten Completed in 3ms
    Running test [issue_3314]ng config:load:flatten Completed in 3ms
    Running test [issue_3327]
    Running test [assign_left]g config:load:flatten Completed in 3ms
    Running test [sub_property] config:load:flatten Completed in 3ms
    Running test [assign_undeclared]ig:load:flatten Completed in 3ms
    Running test [Infinity_assignment]
    Running test [issue_3439_1] config:load:flatten Completed in 3ms
    Running test [issue_3439_2] config:load:flatten Completed in 3ms
    Running test [cond_sequence_return_1]
    Running test [cond_sequence_return_2]ad:flatten Completed in 3ms
    Running test [issue_3520]ng config:load:flatten Completed in 3ms
    Running test [issue_3526_1] config:load:flatten Completed in 3ms
    Running test [issue_3526_2] config:load:flatten Completed in 3ms
    Running test [issue_3562]
    Running test [dot_throw_assign_sequence]flatten Completed in 3ms
    Running test [call_assign_order]ig:load:flatten Completed in 3ms
    Running test [issue_3573]
    Running test [issue_3581_1] config:load:flatten Completed in 3ms
    Running test [issue_3581_2] config:load:flatten Completed in 3ms
    Running test [issue_3596]ng config:load:flatten Completed in 3ms
    Running test [local_value_replacement]d:flatten Completed in 3ms
    Running test [array_in_object_1]
    Running test [array_in_object_2]ig:load:flatten Completed in 3ms
    Running test [array_in_conditional]load:flatten Completed in 3ms
    Running test [object_in_conditional]
    Running test [sequence_in_iife_1]g:load:flatten Completed in 3ms
    Running test [sequence_in_iife_2]
    Running test [sequence_in_iife_3]g:load:flatten Completed in 3ms
    Running test [retain_assign]config:load:flatten Completed in 3ms
    Running test [getter_side_effect]
    Running test [setter_side_effect]g:load:flatten Completed in 3ms
    Running test [substitution_assign]:load:flatten Completed in 3ms
    Running test [substitution_arithmetic]d:flatten Completed in 3ms
    Running test [substitution_logical_1]ad:flatten Completed in 3ms
    Running test [substitution_logical_2]
    Running test [substitution_logical_3]ad:flatten Completed in 3ms
    Running test [substitution_conditional]:flatten Completed in 3ms
    Running test [substitution_unary]g:load:flatten Completed in 3ms
    Running test [issue_3626_1] config:load:flatten Completed in 3ms
    Running test [issue_3626_2] config:load:flatten Completed in 3ms
    Running test [issue_3628_1]
    Running test [issue_3628_2] config:load:flatten Completed in 3ms
    Running test [issue_3641]
    Running test [issue_3651]ng config:load:flatten Completed in 3ms
    Running test [issue_3671]ng config:load:flatten Completed in 3ms
    Running test [call_1]timing config:load:flatten Completed in 3ms
    Running test [call_1_symbol]config:load:flatten Completed in 3ms
    Running test [call_2]timing config:load:flatten Completed in 3ms
    Running test [call_2_symbol]
    Running test [call_3]timing config:load:flatten Completed in 3ms
    Running test [call_3_symbol]config:load:flatten Completed in 3ms
    Running test [issue_3698_1] config:load:flatten Completed in 3ms
    Running test [issue_3698_2]
    Running test [issue_3698_3] config:load:flatten Completed in 3ms
    Running test [issue_3700]ng config:load:flatten Completed in 3ms
    Running test [issue_3744]ng config:load:flatten Completed in 3ms
    Running test [assign_value_def]fig:load:flatten Completed in 3ms
    Running test [join_vars_value_def]:load:flatten Completed in 3ms
    Running test [var_value_def]config:load:flatten Completed in 3ms
    Running test [mangleable_var]onfig:load:flatten Completed in 3ms
    Running test [mangleable_assignment_1]d:flatten Completed in 3ms
    Running test [mangleable_assignment_2]d:flatten Completed in 3ms
    Running test [issue_3884_1] config:load:flatten Completed in 3ms
    Running test [issue_3884_2]
    Running test [issue_3891]ng config:load:flatten Completed in 3ms
    Running test [issue_3894]ng config:load:flatten Completed in 3ms
    Running test [issue_3897]ng config:load:flatten Completed in 3ms
    Running test [issue_3908]ng config:load:flatten Completed in 3ms
    Running test [issue_3927]
    Running test [operator_in]g config:load:flatten Completed in 3ms
    Running test [issue_3971]ng config:load:flatten Completed in 3ms
    Running test [issue_3976]
    Running test [issue_4012]ng config:load:flatten Completed in 3ms
    Running test [global_assign]config:load:flatten Completed in 3ms
    Running test [global_read]
    Running test [issue_4038]ng config:load:flatten Completed in 3ms
    Running test [issue_4040]ng config:load:flatten Completed in 3ms
    Running test [issue_4047_1]
    Running test [issue_4047_2] config:load:flatten Completed in 3ms
    Running test [issue_4051]ng config:load:flatten Completed in 3ms
    Running test [issue_4070]ng config:load:flatten Completed in 3ms
    Running test [issue_4242]
    Running test [issue_4248]ng config:load:flatten Completed in 3ms
    Running test [issue_4430_1] config:load:flatten Completed in 3ms
    Running test [issue_4430_2]
    Running test [collapse_and_assign]:load:flatten Completed in 3ms
    Running test [collapse_and_assign_property]tten Completed in 3ms
    Running test [collapse_or_assign]
    Running test [issue_4586_1] config:load:flatten Completed in 3ms
    Running test [issue_4586_2]
    Running test [issue_4732_1] config:load:flatten Completed in 3ms
    Running test [issue_4732_2]
    Running test [dot_in_try]ng config:load:flatten Completed in 3ms
    Running test [dot_non_local]
    Running test [issue_4806]ng config:load:flatten Completed in 3ms
    Running test [issue_4852]ng config:load:flatten Completed in 3ms
    Running test [issue_4865]ng config:load:flatten Completed in 3ms
    Running test [issue_4868]ng config:load:flatten Completed in 3ms
    Running test [issue_4874]ng config:load:flatten Completed in 3ms
    Running test [issue_4891]
    Running test [issue_4895]ng config:load:flatten Completed in 3ms
    Running test [issue_4908]ng config:load:flatten Completed in 3ms

Additional information

It is now becoming a major nuisance since it affects LTS version of Node.js

Please either fix or revert this buggy version of npm from Node.js

See: npm/cli#5024

@MoLow MoLow added the npm Issues and PRs related to the npm client dependency or the npm registry. label Aug 26, 2022
@tniessen
Copy link
Member

Please either fix or revert this buggy version of npm from Node.js

The Node.js team cannot fix npm directly. npm is maintained by GitHub. Once a new version is published by the npm team, you can update npm independently of Node.js.

@alexlamsl
Copy link
Author

Then please revert npm included with Node.js v16 (LTS) to the last known good version.

You can always update npm independently of Node.js, as you so stated.

@tniessen
Copy link
Member

You can always update npm independently of Node.js, as you so stated.

Similarly, you should be able to downgrade using npm i -g [email protected] (or whatever old version you want).

@alexlamsl
Copy link
Author

So what you imply here is that a major version of Node.js marked as LTS does not exhibit any forms of stability and/or compatibility?

Should I be sticking with EOL versions instead to ensure things won't be broken any further?

@tniessen
Copy link
Member

So what you imply here is that a major version of Node.js marked as LTS does not exhibit any forms of stability and/or compatibility?

I'm sorry, how and where did I imply that? This is one of the most ridiculous straw men I have ever seen and if you insist on resorting to logical fallacies instead of having a useful discussion, I don't think myself or other project maintainers will have much interest in discussing this with you.

I explained to you that we cannot fix the alleged bug in npm ourselves because we do not maintain npm (#44406 (comment)).

I also gave you a solution that should allow you to work around the issue locally by installing a version of npm that suits your needs without having to switch to a different version of Node.js (#44406 (comment)).

I did not give you an answer as to whether we would downgrade npm on the v16 release line for various reasons:

  • I don't know when the next v16 release will be.
  • I don't know if there is an actual bug in npm (the issue does not appear to have been triaged by the npm team).
  • If there is a bug in npm, I don't know if its severity justifies the effort of preparing a new release of Node.js.
  • If there is a bug in npm, I don't know if the npm team will fix it before we could potentially prepare a new v16 release with a downgraded version of npm.
  • I don't know if we can downgrade npm without breaking anything (maybe some feature or bug fix was added along with or after the alleged bug).

Should I be sticking with EOL versions instead to ensure things won't be broken any further?

Following your attempt at logical conclusions, are you certain that downgrading npm will not break anything? Are there no features or bug fixes that would be undone by an npm downgrade and that some v16 users might rely upon? Those are the stability guarantees you seem to desire, so please make sure that downgrading npm will provide those guarantees.


You can, of course, open PRs against npm or against Node.js to either fix the bug or to propose some other solution, such as downgrading npm, and they will go through the regular review process.

@alexlamsl
Copy link
Author

I did not give you an answer as to whether we would downgrade npm on the v16 release line for various reasons:

  • I don't know when the next v16 release will be.
  • I don't know if there is an actual bug in npm (the issue does not appear to have been triaged by the npm team).
  • If there is a bug in npm, I don't know if its severity justifies the effort of preparing a new release of Node.js.
  • If there is a bug in npm, I don't know if the npm team will fix it before we could potentially prepare a new v16 release with a downgraded version of npm.
  • I don't know if we can downgrade npm without breaking anything (maybe some feature or bug fix was added along with or after the alleged bug).

Thanks for the clarification − I was under the (mistaken) impression that this issue will not be rectified going forward.

Please accept my sincere apology.

Though I am confused as to why this rather visible issue managed to slip through the Node.js release process after it has been reported for months, I understand that no procedure's perfect and as long as the goal is to eventually address the issue at hand, I will just roll back to the last version of Node.js v16 that does not bundle this latest version of npm.

@Trott
Copy link
Member

Trott commented Aug 27, 2022

Though I am confused as to why this rather visible issue managed to slip through the Node.js release process after it has been reported for months

It does seem like this issue should have been caught by CITGM, which I believe the releasers run, but maybe only when they expect a breaking change and therefore not on LTS releases. I'm not 100% sure of the process there. I'm also not 100% sure of how the lookup.json in CITGM works, but it does appear that UglifyJS is skipped as flaky in at least some situations. Maybe @nodejs/releasers and/or @nodejs/citgm can shed a little light.

If the issue is the lookup.json settings, it's possible that there's either a bug to fix in UglifyJS or a quirk on our end to accommodate.

If the issue is that we don't run CITGM on LTS releases, I doubt that's going to change (because the release process is already onerous enough) but something we can do is run CITGM on every PR that updates npm. I know we like to fast-track those npm PRs, but the risk of breaking the ecosystem is real. (Something we can do in addition or instead is run CITGM nightly, but we may already do that, and the issue with nightly runs is that people tend to not look at them. I used to watch the daily CI run and I'm pretty sure I'm the only one. I stopped and it's been failing for months at this point.)

@BethGriggs
Copy link
Member

It does seem like this issue should have been caught by CITGM, which I believe the releasers run, but maybe only when they expect a breaking change and therefore not on LTS releases

CITGM should be run on every release, and it usually is as it is part of the documented release process. We only rarely do not run it - typically only in the case of urgent security or bug fixes where we know the CITGM run results would be unlikely to alter our decision to include a patch.

but it does appear that UglifyJS is skipped as flaky in at least some situations.

With "skip": ["12", true], - I believe true means that it's skipped on all versions, all platforms, all of the time - so it's not entirely unexpected that this regression was missed. The likely path is that is that this module was failing consistently or very flaky before for another reason, so was marked skipped, which has masked this new error.

This is a general issue with CITGM right now. Last time I crunched the numbers, I realised of the 115 modules we had in the lookup at the time, at least 85 were marked as skipped or flaky on at least one platform or version. Both skip and flaky will mask errors. CITGM failures per run are ranging from 65-120 recently, which includes a lot of noise for the releaser to sift through to try and identify any new regressions. All of this unfortunately means we're less likely to catch regressions.

Releasers and various other contributors have worked to keep on top of the CITGM failures/flakes to keep the regression tool working as effectively as possible, but it's a never-ending challenge with too few people. Our team at Red Hat even had a dedicated 'CITGM greenness day' to try and resolve some failures and reduce noise but it was soon back up to where it is now. To resolve this I think we either need to be encouraging more contributions to keeping CITGM healthy, or explore alternative approaches.

@targos
Copy link
Member

targos commented Aug 28, 2022

I haven't had time to look into that specific issue, but if the only thing it does is add annoying logs to the output, CITGM wouldn't be able to catch the problem.

@alexlamsl
Copy link
Author

If you look at the issue reported in npm, you'll see that the problem is not specific to UglifyJS at all − the example is just to illustrate how it affects very basic use cases.

Assuming this version of npm went into Node.js v18 before eventually making its way into v16 LTS, I would have encountered and reported it earlier if it weren't for the showstopper #43129 which means I haven't been able to use v18 on any development environments.

@MylesBorins
Copy link
Contributor

Hey all... I've surfaced this with the @nodejs/npm team to figure out what's going on and if we can get this fixed soon. As mentioned above by targos there are a number of other bugs fixed in the newer versions of npm so I don't think we should consider reverting. This also doesn't seem to be breaking enough to require an emergency LTS release, but please correct me if you disagree.

Will aim to get an answer from the team about timeline on a fix, but since I haven't dug in it is possible this might be quite a bit of work to get done, will lyk as soon as I do.

@ruyadorno
Copy link
Member

This also doesn't seem to be breaking enough to require an emergency LTS release, but please correct me if you disagree.

Thanks for looking into this @MylesBorins! It's a terminal display glitch as far as I can tell from npm/cli#5024 and running the reproduction steps provided in this issue. I don't believe this warrants an extra LTS release outside the regular release cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

No branches or pull requests

8 participants