-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_runner: add timeout for tests #43490
Comments
CC @benjamingr Please ping relevant people and add a label? |
@nodejs/test_runner |
Yes, this is a good idea and I am in favor. Is this something you'd like to work on? |
Yes, assuming no objections |
No objections - this is something we should definitely support. |
PR-URL: #43505 Refs: #43490 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs/node#43505 Refs: nodejs/node#43490 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> (cherry picked from commit c1d659591d1c5a6002e762549ee46b69d495b70b)
PR-URL: nodejs/node#43505 Refs: nodejs/node#43490 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> (cherry picked from commit c1d659591d1c5a6002e762549ee46b69d495b70b)
PR-URL: nodejs/node#43505 Refs: nodejs/node#43490 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> (cherry picked from commit c1d659591d1c5a6002e762549ee46b69d495b70b)
PR-URL: #43505 Refs: #43490 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #43505 Refs: #43490 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs/node#43505 Refs: nodejs/node#43490 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Has this been implemented? |
Yeah there is a timeout parameter now check the test runner docs. @bitflower |
Thanks for the feedback @benjamingr ! Sorry to not report back. I had found it in the meantime (it's different to e.g. |
What is the problem this feature will solve?
currently - tests can easily be stuck or never end, which makes it very hard to understand and locate where your problem might originate
for example, this program will be very hard to debug:
What is the feature you are proposing to solve the problem?
add a timeout to tests running via
node:test
, I propose adding a default timeout that will be configurableone of the most important parts of testing is failing fast and knowing what the failure is, and timing out will help determine which test is misfunctioning
What alternatives have you considered?
No response
The text was updated successfully, but these errors were encountered: