-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate flaky crash in test/pummel/test-repl-empty-maybelocal-crash.js
on freebsd
#42719
Comments
Refs: nodejs#42719 Signed-off-by: Darshan Sen <[email protected]>
Refs: nodejs#42719 Signed-off-by: Darshan Sen <[email protected]>
The issue seems similar to #41513 (review) |
@targos if you're talking about the freebsd error in this CI run - #41513 (comment), i.e., the |
I have suspicions that the new test is causing the disconnects on fedora-latest, e.g. https://ci.nodejs.org/job/node-test-commit-linux/nodes=fedora-latest-x64/45410/console -- it looks like the OOM Killer is stepping in. I don't have definitive proof it is this test, but we're in the area of executing the pummel tests and this has only started happening recently. journalctl logs
The droplet has 4 GB of memory. Also this is different from the NIO disconnects we've seen elsewhere caused by Jenkins ping timeouts -- there's no corresponding ping thread timeout message in the Jenkins server log. |
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: nodejs#42719 Signed-off-by: Darshan Sen <[email protected]>
Landed in 19064be |
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: nodejs#42719 Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs#42720 Fixes: nodejs#42719 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Stewart X Addison <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: nodejs#42719 Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs#42720 Fixes: nodejs#42719 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Stewart X Addison <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: nodejs#42719 Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs#42720 Fixes: nodejs#42719 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Stewart X Addison <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: #42719 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42720 Fixes: #42719 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Stewart X Addison <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: #42719 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42720 Backport-PR-URL: #42967 Fixes: #42719 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Stewart X Addison <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: #42719 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #42720 Backport-PR-URL: #42967 Fixes: #42719 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Stewart X Addison <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
The problem doesn't seem completely fixed. New test crashes sometimes on freebsd:
https://ci.nodejs.org/job/node-test-commit-freebsd/43628/
https://ci.nodejs.org/job/node-test-commit-freebsd/43633/
Originally posted by @targos in #42409 (comment)
The text was updated successfully, but these errors were encountered: