Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in fetch_module - "[stdin" instead of "[stdin]"? #41922

Closed
scovetta opened this issue Feb 10, 2022 · 1 comment · Fixed by #41924
Closed

Typo in fetch_module - "[stdin" instead of "[stdin]"? #41922

scovetta opened this issue Feb 10, 2022 · 1 comment · Fixed by #41924

Comments

@scovetta
Copy link
Contributor

Version

(master)

Platform

n/a

Subsystem

n/a

What steps will reproduce the bug?

Affected file:
https://github.com/nodejs/node/blob/master/lib/internal/modules/esm/fetch_module.js#L270

I noticed what looks like a minor bug in the recently merged https imports PR:

image

(I think [stdin should be [stdin].)

Happy to send over a PR, but I don't have a lot of context -- my apologies if this is intentional.

How often does it reproduce? Is there a required condition?

n/a

What is the expected behavior?

n/a

What do you see instead?

n/a

Additional information

n/a
@scovetta scovetta changed the title Typo in fetch_module? Typo in fetch_module - "[stdin" instead of "[stdin]"? Feb 10, 2022
@aduh95
Copy link
Contributor

aduh95 commented Feb 10, 2022 •
edited
Loading

That looks to be indeed incorrect, would you like to send a PR to fix that?

scovetta added a commit to scovetta/node that referenced this issue Feb 10, 2022
@scovetta
Fixes nodejs#41922 (typo / "[stdin")
41be04b 
This PR fixes a minor typo in fetchModule's check for `[eval]` and `[stdin]` parent names.
@scovetta scovetta mentioned this issue Feb 10, 2022
Merged
aduh95 pushed a commit that referenced this issue Feb 12, 2022
@scovetta
esm: fix typo in fetch_module
30c742f 
This PR fixes a minor typo in fetchModule's check for `[eval]` and
`[stdin]` parent names.

PR-URL: #41924
Fixes: #41922
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
bengl pushed a commit to bengl/node that referenced this issue Feb 21, 2022
@scovetta @bengl
esm: fix typo in fetch_module
eb2f821 
This PR fixes a minor typo in fetchModule's check for `[eval]` and
`[stdin]` parent names.

PR-URL: nodejs#41924
Fixes: nodejs#41922
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
bengl pushed a commit that referenced this issue Feb 22, 2022
@scovetta @bengl
esm: fix typo in fetch_module
66c9565 
This PR fixes a minor typo in fetchModule's check for `[eval]` and
`[stdin]` parent names.

PR-URL: #41924
Fixes: #41922
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit to danielleadams/node that referenced this issue Apr 21, 2022
@scovetta @danielleadams
esm: fix typo in fetch_module
ee50112 
This PR fixes a minor typo in fetchModule's check for `[eval]` and
`[stdin]` parent names.

PR-URL: nodejs#41924
Fixes: nodejs#41922
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
@scovetta @danielleadams
esm: fix typo in fetch_module
47cefec 
This PR fixes a minor typo in fetchModule's check for `[eval]` and
`[stdin]` parent names.

PR-URL: #41924
Fixes: #41922
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

esm: fix typo in fetch_module scovetta/node
2 participants
@scovetta @aduh95