test/parallel/test-v8-serdes: You probably don't want to test the exact binary V8 ValueSerializer produces #41519

marjakh · 2022-01-14T13:11:27Z

Version

No response

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

The test has this subtest:

{
  const buf = Buffer.from('ff0d6f2203666f6f5e007b01', 'hex');

  const des = new v8.DefaultDeserializer(buf);
  des.readHeader();

  const ser = new v8.DefaultSerializer();
  ser.writeHeader();

  ser.writeValue(des.readValue());

  assert.deepStrictEqual(buf, ser.releaseBuffer()); <<< here
  assert.strictEqual(des.getWireFormatVersion(), 0x0d);
}

Where you're asserting that V8's ValueSerializer produces exactly this buffer when you serialize a TypedArray.

Asserting this prevents V8 from upgrading the ValueSerializer format and is generally not very useful.

The guarantee we have though is that you can still deserialize this exact data and you'll get a TypedArray, since the format is backwards-compatible.

What we don't guarantee is that if you serialize the TypedArray again, you'll get this exact buffer back. Note that the buffer contains the ValueSerializer version number (the first 0d right after ff). We don't guarantee that we don't ever upgrade the version.

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

(See above)

Additional information

No response

The text was updated successfully, but these errors were encountered:

marjakh · 2022-01-14T13:12:33Z

cc @addaleax who added this test

V8 changed the serialization format so we cannot expect that a value serialized by an old version can be reserialized to the same bytes. Change the test to expect that deserialization of the old value still works. Closes: nodejs#41519

V8 changed the serialization format so we cannot expect that a value serialized by an old version can be reserialized to the same bytes. Change the test to expect that deserialization of the old value still works. Closes: #41519

V8 changed the serialization format so we cannot expect that a value serialized by an old version can be reserialized to the same bytes. Change the test to expect that deserialization of the old value still works. Closes: nodejs/node#41519

V8 changed the serialization format so we cannot expect that a value serialized by an old version can be reserialized to the same bytes. Change the test to expect that deserialization of the old value still works. Closes: #41519

V8 changed the serialization format so we cannot expect that a value serialized by an old version can be reserialized to the same bytes. Change the test to expect that deserialization of the old value still works. Closes: nodejs#41519

V8 changed the serialization format so we cannot expect that a value serialized by an old version can be reserialized to the same bytes. Change the test to expect that deserialization of the old value still works. Closes: nodejs/node#41519

V8 changed the serialization format so we cannot expect that a value serialized by an old version can be reserialized to the same bytes. Change the test to expect that deserialization of the old value still works. Closes: #41519

V8 changed the serialization format so we cannot expect that a value serialized by an old version can be reserialized to the same bytes. Change the test to expect that deserialization of the old value still works. Closes: nodejs#41519

V8 changed the serialization format so we cannot expect that a value serialized by an old version can be reserialized to the same bytes. Change the test to expect that deserialization of the old value still works. Closes: nodejs/node#41519

V8 changed the serialization format so we cannot expect that a value serialized by an old version can be reserialized to the same bytes. Change the test to expect that deserialization of the old value still works. Add another test which is expected to fail when the format changes so that we are aware when it happens and can call it out in the release notes. Closes: nodejs#41519

V8 changed the serialization format so we cannot expect that a value serialized by an old version can be reserialized to the same bytes. Change the test to expect that deserialization of the old value still works. Closes: nodejs/node#41519

V8 changed the serialization format so we cannot expect that a value serialized by an old version can be reserialized to the same bytes. Change the test to expect that deserialization of the old value still works. Closes: #41519

V8 changed the serialization format so we cannot expect that a value serialized by an old version can be reserialized to the same bytes. Change the test to expect that deserialization of the old value still works. Add another test which is expected to fail when the format changes so that we are aware when it happens and can call it out in the release notes. Closes: nodejs/node#41519

V8 changed the serialization format so we cannot expect that a value serialized by an old version can be reserialized to the same bytes. Change the test to expect that deserialization of the old value still works. Add another test which is expected to fail when the format changes so that we are aware when it happens and can call it out in the release notes. Closes: nodejs#41519

V8 changed the serialization format so we cannot expect that a value serialized by an old version can be reserialized to the same bytes. Change the test to expect that deserialization of the old value still works. Add another test which is expected to fail when the format changes so that we are aware when it happens and can call it out in the release notes. Closes: nodejs/node#41519

V8 changed the serialization format so we cannot expect that a value serialized by an old version can be reserialized to the same bytes. Change the test to expect that deserialization of the old value still works. Add another test which is expected to fail when the format changes so that we are aware when it happens and can call it out in the release notes. Closes: #41519