Broken CI

[BridgeAR]

Something landed recently related to eslint and broke our CI.

https://ci.nodejs.org/job/node-test-commit-linux-containered/29888/#showFailuresLink

I guess it might be the most recent eslint update #41085. Seems like we do not require a CI run to land updates in tools? We might want to reconsider that.

/home/iojs/build/workspace/node-test-commit-linux-containered/tools/node_modules/eslint/lib/rules/utils/unicode/is-combining-character.js:12
    return /^[\p{Mc}\p{Me}\p{Mn}]$/u.test(String.fromCodePoint(codePoint));
           ^^^^^^^^^^^^^^^^^^^^^^^^^

SyntaxError: Invalid regular expression: /^[\p{Mc}\p{Me}\p{Mn}]$/: Invalid property name in character class
    at Object.compileFunction (node:vm:352:18)
    at wrapSafe (node:internal/modules/cjs/loader:1026:15)
    at Module._compile (node:internal/modules/cjs/loader:1061:27)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1149:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:999:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/tools/node_modules/eslint/lib/rules/utils/unicode/index.js:7:27)
    at Module._compile (node:internal/modules/cjs/loader:1097:14)

Node.js v18.0.0-pre

Test Result (19 failures / ±0)
test.parallel/test-eslint-async-iife-no-unused-result
test.parallel/test-eslint-alphabetize-errors
test.parallel/test-eslint-crypto-check
test.parallel/test-eslint-documented-errors
test.parallel/test-eslint-duplicate-requires
test.parallel/test-eslint-eslint-check
test.parallel/test-eslint-inspector-check
test.parallel/test-eslint-lowercase-name-for-primitive
test.parallel/test-eslint-no-array-destructuring
test.parallel/test-eslint-no-unescaped-regexp-dot
test.parallel/test-eslint-non-ascii-character
test.parallel/test-eslint-prefer-assert-iferror
test.parallel/test-eslint-prefer-common-mustnotcall
test.parallel/test-eslint-prefer-assert-methods
test.parallel/test-eslint-prefer-common-mustsucceed
test.parallel/test-eslint-prefer-primordials
test.parallel/test-eslint-prefer-util-format-errors
test.parallel/test-eslint-require-common-first
test.parallel/test-eslint-required-modules

[richardlau]

I guess it might be the most recent eslint update #41085. Seems like we do not require a CI run to land updates in tools? We might want to reconsider that.

+1 We hit a similar issue with doc generation in #41077 that a CI run would have flagged.

[BridgeAR]

We are probably going to frequently run into similar issues with other libraries using these character classes as well. More and more libraries use them and we can't update those anymore without finding a solution.

[Trott]

Fixed in #41105. Approval and fast-track would be great.