-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inspection of error with cause fails for non-error causes #41096
Labels
Comments
targos
added
confirmed-bug
Issues with confirmed bugs.
util
Issues and PRs related to the built-in util module.
labels
Dec 6, 2021
/cc @BridgeAR |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this issue
Dec 6, 2021
An error cause may be of any type. Handle all of them, no matter if they are an error or not. Fixes: nodejs#41096 Signed-off-by: Ruben Bridgewater <[email protected]>
BridgeAR
added a commit
to BridgeAR/node
that referenced
this issue
Dec 6, 2021
An error cause may be of any type. Handle all of them, no matter if they are an error or not. Fixes: nodejs#41096 Signed-off-by: Ruben Bridgewater <[email protected]>
BridgeAR
added a commit
to BridgeAR/node
that referenced
this issue
Dec 6, 2021
An error cause may be of any type. Handle all of them, no matter if they are an error or not. Fixes: nodejs#41096 Signed-off-by: Ruben Bridgewater <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this issue
Dec 11, 2021
Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #41097 Fixes: #41096 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
danielleadams
pushed a commit
that referenced
this issue
Dec 14, 2021
An error cause may be of any type. Handle all of them, no matter if they are an error or not. Fixes: #41096 Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #41097 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
danielleadams
pushed a commit
that referenced
this issue
Dec 14, 2021
Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #41097 Fixes: #41096 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
danielleadams
pushed a commit
that referenced
this issue
Jan 31, 2022
An error cause may be of any type. Handle all of them, no matter if they are an error or not. Fixes: #41096 Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #41097 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
danielleadams
pushed a commit
that referenced
this issue
Jan 31, 2022
Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #41097 Fixes: #41096 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
danielleadams
pushed a commit
that referenced
this issue
Jan 31, 2022
An error cause may be of any type. Handle all of them, no matter if they are an error or not. Fixes: #41096 Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #41097 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
danielleadams
pushed a commit
that referenced
this issue
Jan 31, 2022
Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #41097 Fixes: #41096 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this issue
Jan 31, 2022
An error cause may be of any type. Handle all of them, no matter if they are an error or not. Fixes: nodejs#41096 Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: nodejs#41097 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this issue
Jan 31, 2022
Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: nodejs#41097 Fixes: nodejs#41096 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
danielleadams
pushed a commit
that referenced
this issue
Feb 1, 2022
An error cause may be of any type. Handle all of them, no matter if they are an error or not. Fixes: #41096 Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #41097 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
danielleadams
pushed a commit
that referenced
this issue
Feb 1, 2022
Signed-off-by: Ruben Bridgewater <[email protected]> PR-URL: #41097 Fixes: #41096 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Version
master
Platform
N/A
Subsystem
util
What steps will reproduce the bug?
./node -p "new Error('test', { cause: 42 })"
How often does it reproduce? Is there a required condition?
Always
What is the expected behavior?
It should be able to serialize non-error causes.
What do you see instead?
Additional information
No response
The text was updated successfully, but these errors were encountered: