Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test - http2-cancel-while-client-reading #40610

Closed
mhdawson opened this issue Oct 26, 2021 · 0 comments
Closed

Investigate flaky test - http2-cancel-while-client-reading #40610

mhdawson opened this issue Oct 26, 2021 · 0 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem.

Comments

@mhdawson
Copy link
Member

  • Test: parallel/test-http2-cancel-while-client-reading
  • Platform: OSX
  • Console Output:
node:events:368
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TLSWrap.onStreamRead (node:internal/stream_base_commons:220:20)
Emitted 'error' event on ServerHttp2Stream instance at:
    at emitErrorNT (node:internal/streams/destroy:164:8)
    at emitErrorCloseNT (node:internal/streams/destroy:129:3)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  errno: -54,
  code: 'ECONNRESET',
  syscall: 'read'
}

Node.js v18.0.0-pre
@Mesteery Mesteery added flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem. labels Oct 26, 2021
lpinca added a commit to lpinca/node that referenced this issue Oct 29, 2021
@lpinca
test: deflake http2-cancel-while-client-reading
3adca25 
Add missing `'error'` event handler.

Fixes: nodejs#40610
@lpinca lpinca mentioned this issue Oct 29, 2021
Closed
targos pushed a commit that referenced this issue Nov 6, 2021
@lpinca @targos
test: deflake http2-cancel-while-client-reading
95fe9bb 
Add missing `'error'` event handler.

Fixes: #40610

PR-URL: #40659
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this issue Nov 25, 2021
@lpinca @BethGriggs
test: deflake http2-cancel-while-client-reading
f114e35 
Add missing `'error'` event handler.

Fixes: #40610

PR-URL: #40659
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: deflake http2-cancel-while-client-reading lpinca/node
2 participants
@mhdawson @Mesteery