Missing header file v8-weak-callback-info.h in v17

[wankdanker]

Version

v17.0.0

Platform

Linux dandesky 5.7.1-050701-generic #202006071230 SMP Sun Jun 7 12:32:55 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Subsystem

header files/native modules

What steps will reproduce the bug?

nvm install v17
npm install [email protected]

How often does it reproduce? Is there a required condition?

Every time.

What is the expected behavior?

The expected behavior is that v8-weak-callback-info.h is included in the headers file that is obtained by node-gyp from https://nodejs.org/download/release/v17.0.0/node-v17.0.0-headers.tar.gz.

What do you see instead?

make: Entering directory '/home/me/projects/node-odbc/build'
  CXX(target) Release/obj.target/odbc_bindings/src/odbc.o
In file included from /home/me/.cache/node-gyp/17.0.0/include/node/v8-object.h:10,
                 from /home/me/.cache/node-gyp/17.0.0/include/node/v8-array-buffer.h:13,
                 from /home/me/.cache/node-gyp/17.0.0/include/node/v8.h:25,
                 from ../src/odbc.cpp:19:
/home/me/.cache/node-gyp/17.0.0/include/node/v8-persistent-handle.h:10:10: fatal error: v8-weak-callback-info.h: No such file or directory
   10 | #include "v8-weak-callback-info.h"  // NOLINT(build/include_directory)
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Additional information

The file v8-persistent-handle.h which is included in the header tar file #includes v8-weak-callback-info.h, but it is not in the tar file.

// Copyright 2021 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#ifndef INCLUDE_V8_PERSISTENT_HANDLE_H_
#define INCLUDE_V8_PERSISTENT_HANDLE_H_

#include "v8-internal.h"            // NOLINT(build/include_directory)
#include "v8-local-handle.h"        // NOLINT(build/include_directory)
#include "v8-weak-callback-info.h"  // NOLINT(build/include_directory)
#include "v8config.h"               // NOLINT(build/include_directory)

Also, commit f9996d5, which updated the v8 include files does not reference v8-weak-callback-info.h

[wankdanker]

Just found this pull request: #40526 which may solve this problem.

Feel free to close this issue if you agree.