Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The commit-queue label should wait for CI #40330

Closed
benjamingr opened this issue Oct 3, 2021 · 1 comment · Fixed by #42377
Closed

The commit-queue label should wait for CI #40330

benjamingr opened this issue Oct 3, 2021 · 1 comment · Fixed by #42377
Labels
feature request Issues that request new features to be added to Node.js. meta Issues and PRs related to the general management of the project.

Comments

@benjamingr
Copy link
Member

Currently if commit-queue is added as a label in nodejs/node while GitHub CI is running it fails with "CI is running" - it should ideally instead wait for CI to finish if there is a running CI currently :]
@richardlau richardlau transferred this issue from nodejs/build Oct 5, 2021
@richardlau
Copy link
Member

Moved this to the main repo as the commit-queue resides there.

@Mesteery Mesteery added build Issues and PRs related to build files or the CI. feature request Issues that request new features to be added to Node.js. meta Issues and PRs related to the general management of the project. and removed build Issues and PRs related to build files or the CI. labels Oct 12, 2021
@meixg meixg mentioned this issue Mar 17, 2022
Merged
nodejs-github-bot pushed a commit that referenced this issue Mar 21, 2022
@meixg
tools: fix skip PR if CI is still running
8f07452 
resolve: #40330

PR-URL: #42377
Fixes: #40330
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Mestery <[email protected]>
juanarbol pushed a commit that referenced this issue Apr 4, 2022
@meixg @juanarbol
tools: fix skip PR if CI is still running
e0bb9fc 
resolve: #40330

PR-URL: #42377
Fixes: #40330
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Mestery <[email protected]>
juanarbol pushed a commit to juanarbol/node that referenced this issue Apr 5, 2022
@meixg @juanarbol
tools: fix skip PR if CI is still running
17770be 
resolve: nodejs#40330

PR-URL: nodejs#42377
Fixes: nodejs#40330
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Mestery <[email protected]>
juanarbol pushed a commit that referenced this issue Apr 6, 2022
@meixg @juanarbol
tools: fix skip PR if CI is still running
9344a06 
resolve: #40330

PR-URL: #42377
Fixes: #40330
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Mestery <[email protected]>
xtx1130 pushed a commit to xtx1130/node that referenced this issue Apr 25, 2022
@meixg @xtx1130
tools: fix skip PR if CI is still running
5fa82c6 
resolve: nodejs#40330

PR-URL: nodejs#42377
Fixes: nodejs#40330
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Mestery <[email protected]>
juanarbol pushed a commit that referenced this issue May 31, 2022
@meixg @juanarbol
tools: fix skip PR if CI is still running
4122a8d 
resolve: #40330

PR-URL: #42377
Fixes: #40330
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Mestery <[email protected]>
danielleadams pushed a commit that referenced this issue Jun 27, 2022
@meixg @danielleadams
tools: fix skip PR if CI is still running
631ce65 
resolve: #40330

PR-URL: #42377
Fixes: #40330
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Mestery <[email protected]>
targos pushed a commit that referenced this issue Jul 11, 2022
@meixg @targos
tools: fix skip PR if CI is still running
4080425 
resolve: #40330

PR-URL: #42377
Fixes: #40330
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Mestery <[email protected]>
targos pushed a commit that referenced this issue Jul 31, 2022
@meixg @targos
tools: fix skip PR if CI is still running
4c0ddff 
resolve: #40330

PR-URL: #42377
Fixes: #40330
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Mestery <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this issue Oct 10, 2022
@meixg @guangwong
tools: fix skip PR if CI is still running
1dd4fc9 
resolve: nodejs/node#40330

PR-URL: nodejs/node#42377
Fixes: nodejs/node#40330
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Mestery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: fix skip PR if CI is still running
3 participants
@benjamingr @richardlau @Mesteery