Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V8 (9.5) has split the v8.h header #39876

Open
targos opened this issue Aug 25, 2021 · 2 comments
Open

V8 (9.5) has split the v8.h header #39876

targos opened this issue Aug 25, 2021 · 2 comments
Labels
v8 engine Issues and PRs related to the V8 dependency.

Comments

@targos
Copy link
Member

targos commented Aug 25, 2021

See v8/v8@ec06bb6

It shouldn't directly impact the Node.js build because v8.h is still here and includes everything it had before, but at least https://github.com/nodejs/node/blob/master/tools/install.py will have to be changed.
@targos targos added the v8 engine Issues and PRs related to the V8 dependency. label Aug 25, 2021
@targos
Copy link
Member Author

targos commented Aug 25, 2021

@nodejs/v8 is there something else that we need to care about? Should we keep using v8.h or try to move to the new smaller headers?

@verwaest
Copy link
Contributor

You can keep using v8.h but using smaller headers can be much more efficient. While I don't expect much churn, if you wait a bit before switching over you might avoid having to update includes a few times over.

@targos targos mentioned this issue Oct 12, 2021
Closed
targos added a commit to targos/node that referenced this issue Oct 12, 2021
@targos
build: include new public V8 headers in distribution
e725c17 
v8.h was split into a multitude of smaller headers.

Refs: nodejs#39876
@targos targos mentioned this issue Oct 12, 2021
Closed
targos added a commit to targos/node that referenced this issue Oct 12, 2021
@targos
src: include specific headers in cares_wrap
bd03606 
Refs: nodejs#39876
mhdawson pushed a commit that referenced this issue Oct 13, 2021
@targos @mhdawson
build: include new public V8 headers in distribution
f9996d5 
v8.h was split into a multitude of smaller headers.

Refs: #39876

PR-URL: #40423
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@targos @verwaest