Readable[AsyncIterator] doesn't handle premature close

[ronag]

createAsyncIterator should throw ERR_STREAM_PREMATURE_CLOSE if 'close' is emitted before 'end'. Right now I think it just silently succeeds.

[daukadolt]

Sounds interesting, can I work on the issue?

[daukadolt]

@ronag can you suggest the correct way to debug node's internal modules?

I'm using Webstorm, and the debugger seems to ignore my breakpoints when it gets into internal modules, but works fine otherwise.

[ronag]

Sorry. I don’t use breakpoint debugging when working with node.

[RaisinTen]

PR: #39117

[daukadolt]

That's confusing and discouraging from your side @RaisinTen.

@ronag can you at least give a feedback on my PR?

Upd: now that I've looked at RaisinTen's PR I see that there are still some parts that I'm missing.

What does this part do?

if (opts.destroyOnReturn || state.autoDestroy) {
        destroyImpl.destroyer(stream, err);
}

[RaisinTen]

I'm sorry, I thought I could work on this as you didn't publish your PR.

[RaisinTen]

What does this part do?

if (opts.destroyOnReturn || state.autoDestroy) {
        destroyImpl.destroyer(stream, err);
}

@daukadolt It destroys the stream if either the destroyOnReturn option or the autoDestroy option have been passed.

[daukadolt]

But I was still working on it 😞 I don't remember any time limit on PR from Contributing.md.

I'm new to the project, so it took me a while to read Contributing.md and all MD's that followed + Readable's internals

[RaisinTen]

There is no time limit on PRs. Anyone can work on any issue whenever they want to without asking for any permission. I didn't know much about the internal code of readable streams either, so I thought it would be nice to shoot a PR and learn few things about it.

[daukadolt]

Can we agree to let me finish the ticket then, @RaisinTen?

[RaisinTen]

@daukadolt No one is stopping you. Please feel free to continue your work. :)