Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.js crashes when calling writeFloatBE with noAssert #3766

Closed
pmq20 opened this issue Nov 11, 2015 · 2 comments
Closed

Node.js crashes when calling writeFloatBE with noAssert #3766

pmq20 opened this issue Nov 11, 2015 · 2 comments
Labels
buffer Issues and PRs related to the buffer subsystem.

Comments

@pmq20
Copy link
Contributor

pmq20 commented Nov 11, 2015

A simple script to crash Node.js follows,

var b = new Buffer(1)
b.writeFloatLE(11.11, 0, true)

screen shot 2015-11-11 at 14 58 05
@pmq20 pmq20 changed the title Node.js crashes when calling Buffer#writeFloatBE with noAssert=true Node.js crashes when calling Buffer#writeFloatBE with noAssert Nov 11, 2015
@pmq20 pmq20 changed the title Node.js crashes when calling Buffer#writeFloatBE with noAssert Node.js crashes when calling writeFloatBE with noAssert Nov 11, 2015
@mscdex mscdex added the buffer Issues and PRs related to the buffer subsystem. label Nov 11, 2015
@pmq20 pmq20 mentioned this issue Nov 11, 2015
Closed
pmq20 added a commit to pmq20/node that referenced this issue Nov 16, 2015
@pmq20
buffer: let WriteFloatGeneric silently drop values
f28cea5 
Fixes nodejs#3766
Fishrock123 pushed a commit that referenced this issue Nov 17, 2015
@pmq20 @Fishrock123
buffer: let WriteFloatGeneric silently drop values
7bff013 
Documentation currently states that setting noAssert and passing a value
larger than can fit in the Buffer will cause data to be silently
dropped. Change implementation to match documented behavior.

Fixes: #3766
Reviewed-By: Trevor Norris <[email protected]>
MylesBorins pushed a commit that referenced this issue Nov 30, 2015
@pmq20
buffer: let WriteFloatGeneric silently drop values
8c9d6c6 
Documentation currently states that setting noAssert and passing a value
larger than can fit in the Buffer will cause data to be silently
dropped. Change implementation to match documented behavior.

Fixes: #3766
Reviewed-By: Trevor Norris <[email protected]>
rvagg pushed a commit that referenced this issue Dec 4, 2015
@pmq20 @rvagg
buffer: let WriteFloatGeneric silently drop values
16ebaf6 
Documentation currently states that setting noAssert and passing a value
larger than can fit in the Buffer will cause data to be silently
dropped. Change implementation to match documented behavior.

Fixes: #3766
Reviewed-By: Trevor Norris <[email protected]>
@jasnell
Copy link
Member

jasnell commented Dec 17, 2015

I believe this is already fixed in v4 but need to confirm

jasnell pushed a commit that referenced this issue Dec 17, 2015
@pmq20 @jasnell
buffer: let WriteFloatGeneric silently drop values
db0186e 
Documentation currently states that setting noAssert and passing a value
larger than can fit in the Buffer will cause data to be silently
dropped. Change implementation to match documented behavior.

Fixes: #3766
Reviewed-By: Trevor Norris <[email protected]>
@trevnorris
Copy link
Contributor

Fixed in v4.2.4-proposal

jasnell pushed a commit that referenced this issue Dec 23, 2015
@pmq20 @jasnell
buffer: let WriteFloatGeneric silently drop values
edcb6c0 
Documentation currently states that setting noAssert and passing a value
larger than can fit in the Buffer will cause data to be silently
dropped. Change implementation to match documented behavior.

Fixes: #3766
Reviewed-By: Trevor Norris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pmq20 @mscdex @trevnorris @jasnell