-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The slicing method in the buffer.Blob is wrong according to the spec #37335
Comments
5 tasks
targos
added a commit
to targos/node
that referenced
this issue
Feb 13, 2021
targos
added a commit
to targos/node
that referenced
this issue
Feb 16, 2021
targos
added a commit
to targos/node
that referenced
this issue
Feb 17, 2021
targos
added a commit
that referenced
this issue
Feb 28, 2021
PR-URL: #37361 Fixes: #37335 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
added a commit
to targos/node
that referenced
this issue
Aug 8, 2021
PR-URL: nodejs#37361 Fixes: nodejs#37335 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
added a commit
to targos/node
that referenced
this issue
Aug 8, 2021
PR-URL: nodejs#37361 Fixes: nodejs#37335 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
added a commit
to targos/node
that referenced
this issue
Aug 13, 2021
PR-URL: nodejs#37361 Fixes: nodejs#37335 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
added a commit
that referenced
this issue
Aug 13, 2021
PR-URL: #37361 Backport-PR-URL: #39704 Fixes: #37335 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this issue
Aug 31, 2021
PR-URL: #37361 Backport-PR-URL: #39704 Fixes: #37335 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
foxxyz
pushed a commit
to foxxyz/node
that referenced
this issue
Oct 18, 2021
PR-URL: nodejs#37361 Backport-PR-URL: nodejs#39704 Fixes: nodejs#37335 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thought I would try it out and help you find some quirks before making it stable. The slicing method is wrong
What steps will reproduce the bug?
How often does it reproduce?
Happens everytime
What is the expected behavior?
...to get a new Blob slice without throwing any error.
the slicing method should behave similar like you slice a String or a ArrayBuffer
But internally it can be more complicated then that if it should operate on multiple blob parts that are async (see #37338)
What do you see instead?
This should not happen.
The text was updated successfully, but these errors were encountered: