-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node v15.6.0 changes the behavior of .end
on zlib.DeflateRaw
#37027
Comments
@nodejs/zlib @nodejs/streams |
The issue seems to be caused by a4fce32. Reverting it makes the example work as expected. |
I think a4fce32 is fine. The documentation does not mention that I would only revert on v15.x and mark #36817 as semver-major. |
Thanks for clarification @mcollina 🙇 |
I'm closing this as it was addressed by #37060. |
@mcollina Why was this not reverted on master? I'm running into the same issue on 16.3.0. |
@severn-everett Because the new behavior is considered correct. |
Downgraded node to ^14.0.0 to fix issue with node-archiver nodejs/node#37027
What steps will reproduce the bug?
The following code:
produces the following output on Node v15.6.0:
On Node v15.5.0 and below, it produces the output:
How often does it reproduce? Is there a required condition?
This reproduces 100% of the time
What is the expected behavior?
Calling
end
should call the overriddenwrite
method with the supplied data, as in Node v15.5.0 and below.What do you see instead?
The overridden
write
method is not called.Additional information
This leads to node-archiver producing invalid ZIP files: archiverjs/node-archiver#491
PR #36618 seems like it might be related
The text was updated successfully, but these errors were encountered: