Noisy warning in configure: WARNING: No acceptable ld.gold linker found!
#35872
Comments
|
pinging @gabrielschulhof (pinged wrong gabriel the first time sorry |
|
I also think that we should only warn about this when |
MylesBorins
added a commit
to MylesBorins/node
that referenced
this issue
Nov 6, 2020
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: nodejs#35872
danielleadams
pushed a commit
that referenced
this issue
Nov 9, 2020
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: #35872 PR-URL: #35955 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this issue
Dec 9, 2020
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: #35872 PR-URL: #35955 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this issue
Dec 10, 2020
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: #35872 PR-URL: #35955 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
pushed a commit
that referenced
this issue
Dec 15, 2020
Currently warning is printed called even if the selection ordering flag has not been passed. Only print warning if `--limit-configure-section-file` has been passed to configure. Fixes: #35872 PR-URL: #35955 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems like this is related to the inclusion of using the ld.gold linker as part of
--use-section-ordering-file.The default compiler setup on OSX does not have these features... further, I don't believe the default configuration for node.js even uses
--use-section-ordering-file. When I saw this warning at first I was worried that there had been some sort of regression in my build tools locally (something that can happen with OSX / Xcode upgrades) and I lots about an hour of time trying to debug things.In the end I really couldn't find an easy way to get the ld.gold linker installed on OSX at all.
With all this in mind I wonder if it might make sense for us to only present the warning if the flag that requires the ld.gold linker is passed.
/cc @gabrielf whom I believe added this feature
The text was updated successfully, but these errors were encountered: