-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL: changes to file URL path normalization #35429
Comments
Will have to check if this messes with any existing stuff using the URL resolver |
I implemented the updated logic of URL at #35477 and the below tests failed atm as they seem to be depending on URL:
Full log: https://gist.github.com/watilde/ff9051a491cdfe0100f10cf525f7bed5 I'm figuring out how we can make them pass without breaking change in the existed modules other than URL. Any advice would be appreciated. |
@watilde if you can track down to what URL inputs and outputs those cases correspond to that would help a lot to determine if these changes should be considered breaking for the module system. |
I just added a full log to my first comment. You can search by "Command:" to find failed cases. |
@watilde thanks, I already looked through them actually but couldn't see which |
@guybedford Thank you for your help! To share where the errors happen, I investigated codes and could figure out how to fix them. Now the PR affects only |
Glad you have tracked it down and thanks for driving this important feedback which also affects Deno and other file-based module resolvers. |
Refs: whatwg/url#544 Refs: web-platform-tests/wpt#25716 PR-URL: nodejs#35477 Fixes: nodejs#35429 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
See whatwg/url#544 and web-platform-tests/wpt#25716 for new tests.
cc @jasnell
The text was updated successfully, but these errors were encountered: