Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: broken links in doc/guides/commit-queue.md #34787

Closed
targos opened this issue Aug 15, 2020 · 0 comments
Closed

doc: broken links in doc/guides/commit-queue.md #34787

targos opened this issue Aug 15, 2020 · 0 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@targos
Copy link
Member

targos commented Aug 15, 2020

This fails on my machine:

./configure --ninja
make test -j12 V=

Running Markdown link checker...
Broken link at /home/mzasso/git/nodejs/node/doc/guides/commit-queue.md:53:5 (/.github/workflows/commit_queue.yml)
Broken link at /home/mzasso/git/nodejs/node/doc/guides/commit-queue.md:76:1 (./tools/actions/commit-queue.sh)
make[1]: *** [Makefile:604: test-doc] Error 1
@targos targos added the doc Issues and PRs related to the documentations. label Aug 15, 2020
@lpinca lpinca mentioned this issue Aug 15, 2020
Closed
3 tasks
lpinca added a commit to lpinca/node that referenced this issue Aug 15, 2020
@lpinca
doc: fix broken links in commit-queue.md
b9fa6f6 
Fixes: nodejs#34787
@richardlau richardlau mentioned this issue Aug 17, 2020
Closed
2 tasks
MylesBorins pushed a commit that referenced this issue Aug 17, 2020
@lpinca @MylesBorins
doc: fix broken links in commit-queue.md
3224091 
Fixes: #34787

PR-URL: #34789
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
Trott pushed a commit that referenced this issue Aug 19, 2020
@richardlau @Trott
build: run link checker in linter workflow
1b87035 
Signed-off-by: Richard Lau <[email protected]>

PR-URL: #34810
Refs: #34787
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Trott pushed a commit that referenced this issue Aug 19, 2020
@richardlau @Trott
doc,tools: annotate broken links in actions workflow
9a819dd 
Change format of logged messages when run on GitHub Actions (i.e.
when the `GITHUB_ACTIONS` environment variable is true) so that
broken links are highlighted inline in pull requests.

Signed-off-by: Richard Lau <[email protected]>

PR-URL: #34810
Refs: #34787
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this issue Aug 20, 2020
@richardlau @BethGriggs
build: run link checker in linter workflow
3ac08be 
Signed-off-by: Richard Lau <[email protected]>

PR-URL: #34810
Refs: #34787
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this issue Aug 20, 2020
@richardlau @BethGriggs
doc,tools: annotate broken links in actions workflow
f464d56 
Change format of logged messages when run on GitHub Actions (i.e.
when the `GITHUB_ACTIONS` environment variable is true) so that
broken links are highlighted inline in pull requests.

Signed-off-by: Richard Lau <[email protected]>

PR-URL: #34810
Refs: #34787
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this issue Aug 20, 2020
@lpinca @BethGriggs
doc: fix broken links in commit-queue.md
e54a684 
Fixes: #34787

PR-URL: #34789
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
BethGriggs pushed a commit that referenced this issue Aug 20, 2020
@richardlau @BethGriggs
build: run link checker in linter workflow
7f0869f 
Signed-off-by: Richard Lau <[email protected]>

PR-URL: #34810
Refs: #34787
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
BethGriggs pushed a commit that referenced this issue Aug 20, 2020
@richardlau @BethGriggs
doc,tools: annotate broken links in actions workflow
cdd4540 
Change format of logged messages when run on GitHub Actions (i.e.
when the `GITHUB_ACTIONS` environment variable is true) so that
broken links are highlighted inline in pull requests.

Signed-off-by: Richard Lau <[email protected]>

PR-URL: #34810
Refs: #34787
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@lpinca @addaleax
doc: fix broken links in commit-queue.md
82811f7 
Fixes: #34787

PR-URL: #34789
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@richardlau @addaleax
build: run link checker in linter workflow
ad4dca3 
Signed-off-by: Richard Lau <[email protected]>

PR-URL: #34810
Refs: #34787
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@richardlau @addaleax
doc,tools: annotate broken links in actions workflow
52ad835 
Change format of logged messages when run on GitHub Actions (i.e.
when the `GITHUB_ACTIONS` environment variable is true) so that
broken links are highlighted inline in pull requests.

Signed-off-by: Richard Lau <[email protected]>

PR-URL: #34810
Refs: #34787
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@lpinca @addaleax
doc: fix broken links in commit-queue.md
c7fc16e 
Fixes: #34787

PR-URL: #34789
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Derek Lewis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Mary Marchini <[email protected]>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@richardlau @addaleax
build: run link checker in linter workflow
ea56aea 
Signed-off-by: Richard Lau <[email protected]>

PR-URL: #34810
Refs: #34787
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
addaleax pushed a commit that referenced this issue Sep 22, 2020
@richardlau @addaleax
doc,tools: annotate broken links in actions workflow
f57104b 
Change format of logged messages when run on GitHub Actions (i.e.
when the `GITHUB_ACTIONS` environment variable is true) so that
broken links are highlighted inline in pull requests.

Signed-off-by: Richard Lau <[email protected]>

PR-URL: #34810
Refs: #34787
Reviewed-By: Mary Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
This was referenced May 27, 2022
Open
Open
@137717unity 137717unity mentioned this issue May 27, 2022
Open
@baby636 baby636 mentioned this issue May 27, 2022
Open
@snyk-bot snyk-bot mentioned this issue May 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this issue May 27, 2022
Open
@ron-a20 ron-a20 mentioned this issue May 27, 2022
Open
@molllyn1 molllyn1 mentioned this issue May 28, 2022
Open
@snyk-bot snyk-bot mentioned this issue Sep 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this issue Sep 26, 2022
Open
@137717unity 137717unity mentioned this issue Sep 26, 2022
Open
@snyk-bot snyk-bot mentioned this issue Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this issue Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this issue Oct 6, 2022
Open
@137717unity 137717unity mentioned this issue Oct 7, 2022
Open
@wedataintelligence wedataintelligence mentioned this issue Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity 137717unity mentioned this issue Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this issue Oct 9, 2022
Open
@kissofire kissofire mentioned this issue Jun 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: fix broken links in commit-queue.md lpinca/node
1 participant
@targos