Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASAN tests failing #34657

Closed
mmarchini opened this issue Aug 7, 2020 · 0 comments
Closed

ASAN tests failing #34657

mmarchini opened this issue Aug 7, 2020 · 0 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@mmarchini
Copy link
Contributor

Failure was introduced in https://github.com/nodejs/node/runs/955870692?check_suite_focus=true apparently.
@mmarchini mmarchini added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Aug 7, 2020
@addaleax addaleax mentioned this issue Aug 7, 2020
Closed
2 tasks
addaleax added a commit to addaleax/node that referenced this issue Aug 7, 2020
@addaleax
n-api: fix use-after-free with napi_remove_async_cleanup_hook
b94ceaf 
Fixes: nodejs#34657
Refs: nodejs#34572
@jasnell jasnell closed this as completed in 9511261 Aug 7, 2020
jasnell pushed a commit that referenced this issue Aug 7, 2020
@addaleax @jasnell
src: spin shutdown loop while immediates are pending
09c5942 
This allows using `SetImmediate()` and friends at any point
during cleanup.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: James M Snell <[email protected]>
jasnell pushed a commit that referenced this issue Aug 7, 2020
@addaleax @jasnell
n-api: fix use-after-free with napi_remove_async_cleanup_hook
262d0d0 
Fixes: #34657
Refs: #34572

PR-URL: #34662
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this issue Aug 8, 2020
@addaleax
src: fix size underflow in CallbackQueue
39ca48c 
Only decrease the size when actually removing items.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this issue Aug 8, 2020
@addaleax
src: spin shutdown loop while immediates are pending
2761f34 
This allows using `SetImmediate()` and friends at any point
during cleanup.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this issue Aug 8, 2020
@addaleax
n-api: fix use-after-free with napi_remove_async_cleanup_hook
fbd411d 
Fixes: #34657
Refs: #34572

PR-URL: #34662
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this issue Aug 11, 2020
@addaleax @codebytere
src: fix size underflow in CallbackQueue
3132878 
Only decrease the size when actually removing items.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this issue Aug 11, 2020
@addaleax @codebytere
src: spin shutdown loop while immediates are pending
4369c2a 
This allows using `SetImmediate()` and friends at any point
during cleanup.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this issue Aug 11, 2020
@addaleax @codebytere
n-api: fix use-after-free with napi_remove_async_cleanup_hook
4ed89a3 
Fixes: #34657
Refs: #34572

PR-URL: #34662
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this issue Sep 22, 2020
@addaleax
src: fix size underflow in CallbackQueue
264f003 
Only decrease the size when actually removing items.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this issue Sep 22, 2020
@addaleax
src: spin shutdown loop while immediates are pending
01107cc 
This allows using `SetImmediate()` and friends at any point
during cleanup.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this issue Sep 22, 2020
@addaleax
src: fix size underflow in CallbackQueue
dabd04d 
Only decrease the size when actually removing items.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this issue Sep 22, 2020
@addaleax
src: spin shutdown loop while immediates are pending
1549048 
This allows using `SetImmediate()` and friends at any point
during cleanup.

PR-URL: #34662
Fixes: #34657
Refs: #34572
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax added a commit that referenced this issue Sep 22, 2020
@addaleax
n-api: fix use-after-free with napi_remove_async_cleanup_hook
c440748 
Fixes: #34657
Refs: #34572

PR-URL: #34662
Reviewed-By: Gabriel Schulhof <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

n-api: fix use-after-free with napi_remove_async_cleanup_hook addaleax/node
1 participant
@mmarchini