Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: end(callback) does not propagate write after end to callback #33684

Open
ronag opened this issue Jun 1, 2020 · 6 comments
Open

stream: end(callback) does not propagate write after end to callback #33684

ronag opened this issue Jun 1, 2020 · 6 comments
Labels
confirmed-bug Issues with confirmed bugs. http Issues or PRs related to the http subsystem. stream Issues and PRs related to the stream subsystem.

Comments

@ronag
Copy link
Member

ronag commented Jun 1, 2020 •
edited
Loading 

w.end();
w.end('asd', (err) => {
  assert.strictEqual(err.code, 'ERR_STREAM_WRITE_AFTER_END'); // Fails
});
@ronag ronag added confirmed-bug Issues with confirmed bugs. stream Issues and PRs related to the stream subsystem. http Issues or PRs related to the http subsystem. labels Jun 1, 2020
@ronag
Copy link
Member Author

ronag commented Jun 1, 2020

Same problem with http.OutgoingMessage.

@ronag ronag mentioned this issue Jun 1, 2020
Closed
4 tasks
@zhangwinning
Copy link
Contributor

zhangwinning commented Jun 7, 2020 •
edited
Loading

@ronag can I solve it?

@ronag
Copy link
Member Author

ronag commented Jun 7, 2020

@zhangwinning sure, go ahead and try

rexagod added a commit to rexagod/node that referenced this issue Jun 7, 2020
@rexagod
stream: propagate end's cb to write
b722039 
Fixes: nodejs#33684
@rexagod rexagod mentioned this issue Jun 7, 2020
Closed
4 tasks
@rexagod
Copy link
Member

rexagod commented Jun 7, 2020

@zhangwinning Sorry, I never saw your comment and created a draft PR. Let me know if you are still working on this and I'll go ahead and close that.

@zhangwinning
Copy link
Contributor

@rexagod yes, I still working it.

@rexagod
Copy link
Member

rexagod commented Jun 7, 2020 •
edited
Loading

No problem. I've closed #33786. Go ahead.

@zhangwinning zhangwinning mentioned this issue Jun 8, 2020
Closed
4 tasks
ronag added a commit to nxtedition/node that referenced this issue Jun 21, 2020
@ronag
stream: propagate write error to end callback
5d289d9 
Properly propagate all write errors throught to
end callback.

Fixes: nodejs#33684
@ronag ronag mentioned this issue Jun 28, 2020
Open
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed-bug Issues with confirmed bugs. http Issues or PRs related to the http subsystem. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
3 participants
@ronag @zhangwinning @rexagod