Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bat files shows as modified when clone repo in linux environment #330

Closed
entertainyou opened this issue Jan 13, 2015 · 2 comments
Closed

Comments

@entertainyou
Copy link
Contributor

When I checked out io.js source code, git status shows as:

On branch v1.x
Your branch is up-to-date with 'origin/v1.x'.
Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git checkout -- ..." to discard changes in working directory)

    modified:   deps/uv/docs/make.bat
    modified:   tools/gyp/gyp.bat
    modified:   tools/gyp/samples/samples.bat
    modified:   tools/wrk/deps/luajit/src/msvcbuild.bat
    modified:   tools/wrk/deps/luajit/src/xedkbuild.bat

Seems caused by 43e4c90, it add '*.bat text eol=crlf' into .gitattributes

@entertainyou entertainyou changed the title bat files shows as modified bat files shows as modified when clone repo in linux environment Jan 13, 2015
@rvagg
Copy link
Member

rvagg commented Jan 13, 2015

yes, ran into this problem trying to practice the release process, will fix in a PR shortly

rvagg added a commit to rvagg/io.js that referenced this issue Jan 13, 2015
rvagg added a commit that referenced this issue Jan 13, 2015
@bnoordhuis
Copy link
Member

I believe this is fixed in e25a175. Thanks for the bug report, @entertainyou.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants