-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusing Documentation on asyncResource.emitDestroy() #32409
Comments
HarshithaKP
added a commit
to HarshithaKP/node
that referenced
this issue
Mar 27, 2020
4 tasks
BethGriggs
pushed a commit
that referenced
this issue
Apr 7, 2020
Fixes: #32409 PR-URL: #32514 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
targos
pushed a commit
that referenced
this issue
Apr 12, 2020
Fixes: #32409 PR-URL: #32514 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
targos
pushed a commit
that referenced
this issue
Apr 22, 2020
Fixes: #32409 PR-URL: #32514 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]>
4 tasks
deepal
added a commit
to deepal/node
that referenced
this issue
May 3, 2021
This updates the documentation of asyncResource.emitDestroy() to match the usage of `requireManualDestroy` option. Refs: nodejs#32409
deepal
added a commit
to deepal/node
that referenced
this issue
May 3, 2021
This updates the documentation of asyncResource.emitDestroy() to match the usage of `requireManualDestroy` option. Refs: nodejs#32409
deepal
added a commit
to deepal/node
that referenced
this issue
May 4, 2021
This updates the documentation of asyncResource.emitDestroy() to match the usage of `requireManualDestroy` option. Refs: nodejs#32409
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Additional information
The behaviour of
asyncResource.emitDestroy()
underasync_hooks
is somewhat confusing.Documentation of the
options.requireManualDestroy
constructor argument property ofAsyncResource
states that:This indicates that
asyncResource.emitDestroy()
is automatically called by default. However, the following section onemitDestroy()
documentation states that:I'm a bit confused about this. Shouldn't this be re-worded in order to convey behaviour of
emitDestroy
clearly?PS: I was wondering whether I should create this issue on help repository, but have a feeling that the documentation might have to be amended. Therefore created the issue here.
The text was updated successfully, but these errors were encountered: