Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint failing #3229

Closed
Trott opened this issue Oct 7, 2015 · 0 comments
Closed

Lint failing #3229

Trott opened this issue Oct 7, 2015 · 0 comments
Assignees
@Trott
Labels
test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Oct 7, 2015

Test added in d1f2404 does not pass linting rule added in 3de353b. PR coming momentarily.
@Trott Trott added the test Issues and PRs related to the tests. label Oct 7, 2015
@Trott Trott self-assigned this Oct 7, 2015
Trott added a commit to Trott/io.js that referenced this issue Oct 7, 2015
@Trott
test: linting for buffer-free-callback test
034aee4 
Test added in d1f2404 does not pass linting rule added in 3de353b.
Fixed in this commit. `common` module required in all tests except
those that intentionally leak variables.

Fixes: nodejs#3229
@Trott Trott mentioned this issue Oct 7, 2015
Closed
@Trott Trott closed this as completed in 6f63a4a Oct 7, 2015
Trott added a commit that referenced this issue Oct 8, 2015
@Trott @jasnell
test: linting for buffer-free-callback test
2d0fe4c 
Test added in d1f2404 does not pass linting rule added in 3de353b.
Fixed in this commit. `common` module required in all tests except
those that intentionally leak variables.

PR-URL: #3230
Fixes: #3229
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Jeremiah Senkpiel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Trott Trott

Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Trott