-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.on('close') for a readable stream stops working when going from node 12.14.0 to 12.16.1 #32023
Labels
zlib
Issues and PRs related to the zlib subsystem.
Comments
bisected to 7cad756 |
tadjik1
pushed a commit
to tadjik1/node
that referenced
this issue
Mar 2, 2020
Call the close method after readable 'end' so that 'close' will be emitted afterwards. Fixes: nodejs#32023
3 tasks
MylesBorins
pushed a commit
that referenced
this issue
Mar 11, 2020
Call the close method after readable 'end' so that 'close' will be emitted afterwards. Fixes: #32023 PR-URL: #32050 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this issue
Mar 11, 2020
Call the close method after readable 'end' so that 'close' will be emitted afterwards. Fixes: nodejs#32023 PR-URL: nodejs#32050 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
ronag
pushed a commit
to nxtedition/node
that referenced
this issue
Mar 11, 2020
Call the close method after readable 'end' so that 'close' will be emitted afterwards. Fixes: nodejs#32023 PR-URL: nodejs#32050 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What steps will reproduce the bug?
The entire script can be found here (https://github.com/americanexpress/one-app/blob/master/scripts/dangers/bundle-sizes.js)
How often does it reproduce? Is there a required condition?
Consistently.
What is the expected behavior?
With this certain piece of code, on close of the stream, a markdown file should be printed.
What do you see instead?
Nothing is printed due to it not closing.
Additional information
Switching
close
toend
makes it work. Also, this comes from a discussion I had with @mcollina and @jasnell on Twitter.The text was updated successfully, but these errors were encountered: