Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement N-API RefTracker class using util's ListHead/ListNode #31639

Closed
gabrielschulhof opened this issue Feb 4, 2020 · 3 comments
Closed

Re-implement N-API RefTracker class using util's ListHead/ListNode #31639

gabrielschulhof opened this issue Feb 4, 2020 · 3 comments
Labels
node-api Issues and PRs related to the Node-API.

Comments

@gabrielschulhof
Copy link
Contributor

Re: #31638 (review)
@gabrielschulhof gabrielschulhof mentioned this issue Feb 4, 2020
Closed
3 tasks
@gabrielschulhof
Copy link
Contributor Author

There may actually be a wrinkle with this: src/js_native_api_v8.h is supposed to be usable even without Node.js. Thus, if we want to use Node.js' implementation, we'll likely have to alias the types from src/js_native_api_v8_internals.h so those using N-API outside of Node.js would have to use their own implementation of ListHead/ListNode. Not a showstopper – just something to keep in mind.

gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Feb 10, 2020
n-api: track refs using ListNode and ListHead
ac78cbb 
Switch to the Node.js doubly-linked list implementation.

Fixes: nodejs#31639
@gabrielschulhof gabrielschulhof mentioned this issue Feb 10, 2020
Closed
2 tasks
@targos
Copy link
Member

targos commented Dec 26, 2020

#31714 stalled. What's the next step?

@targos targos added the node-api Issues and PRs related to the Node-API. label Dec 26, 2020
@gabrielschulhof
Copy link
Contributor Author

@targos I think given the performance issues uncovered in the PR and the issue I mention above, I think we can close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

n-api: track refs using ListNode and ListHead gabrielschulhof/node
2 participants
@gabrielschulhof @targos