Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: <code> blocks in headings not rendered correctly #31451

Closed
GeoffreyBooth opened this issue Jan 21, 2020 · 2 comments
Closed

docs: <code> blocks in headings not rendered correctly #31451

GeoffreyBooth opened this issue Jan 21, 2020 · 2 comments
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.

Comments

@GeoffreyBooth
Copy link
Member

GeoffreyBooth commented Jan 21, 2020

See e.g. https://nodejs.org/api/esm.html#esm_package_json_type_field. The text "type" should be rendered as a code block, yet instead it’s rendered as normal text with wide margins on either side. In earlier versions I tried using backticks but they weren’t supported in Markdown headings.

cc @Trott

@GeoffreyBooth GeoffreyBooth added doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. labels Jan 21, 2020
@himself65
Copy link
Member

commit fdec6bd changed this style

h1, h1 code,
h2, h2 code,
h3, h3 code,
h4, h4 code,
h5, h5 code,
h6, h6 code {
background-color: inherit;
color: inherit;
font-family: inherit;
font-weight: 700;
line-height: inherit;
position: relative;
margin: 1.5rem 0 1rem;
padding: inherit;
text-rendering: optimizeLegibility;
}

Trott added a commit to Trott/io.js that referenced this issue Jan 22, 2020
@Trott
Copy link
Member

Trott commented Jan 22, 2020

Hopeful fix in #31451.

image of a cartoon character trying to adjust a window shade over and over, eventually destroying it, labeled "CSS"

@Trott Trott closed this as completed in d32a715 Jan 24, 2020
codebytere pushed a commit that referenced this issue Feb 17, 2020
Fixes: #31451

PR-URL: #31460
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this issue Mar 15, 2020
Fixes: #31451

PR-URL: #31460
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
codebytere pushed a commit that referenced this issue Mar 17, 2020
Fixes: #31451

PR-URL: #31460
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants