Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.getHeapSpaceStatistics() link to GetHeapSpaceStatistics() is broken #31181

Closed
sam-github opened this issue Jan 3, 2020 · 2 comments
Closed
Labels
doc Issues and PRs related to the documentations. v8 module Issues and PRs related to the "v8" subsystem.

Comments

@sam-github
Copy link
Contributor

https://nodejs.org/api/v8.html#v8_v8_getheapspacestatistics

  • Version: current
  • Platform: n/a
  • Subsystem: doc

https://nodejs.org/api/v8.html#v8_v8_getheapspacestatistics links to https://v8docs.nodesource.com/node-10.6/d5/dda/classv8_1_1_isolate.html#ac673576f24fdc7a33378f8f57e1d13a4 which is 404.

It should be replaced with a more stable link, if one exists, though I can't find one.

@sam-github sam-github added doc Issues and PRs related to the documentations. v8 module Issues and PRs related to the "v8" subsystem. labels Jan 3, 2020
@Trott
Copy link
Member

Trott commented Jan 4, 2020

https://v8docs.nodesource.com/node-13.2/d5/dda/classv8_1_1_isolate.html#ac673576f24fdc7a33378f8f57e1d13a4 would be a quick fix, but yeah, something that seemed a little more permanent would be great.

@dev-script
Copy link
Contributor

I would like to work on this issue.

@Trott Trott closed this as completed in 2a94c9f Jan 11, 2020
MylesBorins pushed a commit that referenced this issue Jan 16, 2020
Link replaced in v8 getHeapSpaceStatistics function because it was
showing 404 page not found.

Fixes: #31181

PR-URL: #31274
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this issue Mar 14, 2020
Link replaced in v8 getHeapSpaceStatistics function because it was
showing 404 page not found.

Fixes: #31181

PR-URL: #31274
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
codebytere pushed a commit that referenced this issue Mar 17, 2020
Link replaced in v8 getHeapSpaceStatistics function because it was
showing 404 page not found.

Fixes: #31181

PR-URL: #31274
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. v8 module Issues and PRs related to the "v8" subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants