Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2.getDefaultSettings().maxConcurrentStreams is undefined #29763

Closed
szmarczak opened this issue Sep 29, 2019 · 2 comments
Closed

http2.getDefaultSettings().maxConcurrentStreams is undefined #29763

szmarczak opened this issue Sep 29, 2019 · 2 comments
Labels
http2 Issues or PRs related to the http2 subsystem.

Comments

@szmarczak
Copy link
Member

As per the docs:

The http2.getDefaultSettings(), [...] APIs either return or receive as input an object that defines configuration settings for an Http2Session object. These objects are ordinary JavaScript objects containing the following properties.
[...]
maxConcurrentStreams <number> Specifies the maximum number of concurrent streams permitted on an Http2Session. There is no default value which implies, at least theoretically, 231-1. streams may be open concurrently at any given time in an Http2Session. The minimum value is 0. The maximum allowed value is 231-1.

$ node
Welcome to Node.js v12.10.0.
Type ".help" for more information.
> http2.getDefaultSettings().maxConcurrentStreams
undefined
@Trott Trott added the http2 Issues or PRs related to the http2 subsystem. label Sep 29, 2019
@szmarczak
Copy link
Member Author

It should not be undefined IMO. It should be 231-1. If there is no default value it should be Infinity.

@ZYSzys ZYSzys mentioned this issue Oct 3, 2019
Closed
4 tasks
@trivikr
Copy link
Member

trivikr commented Oct 4, 2019

Link to the docs: https://nodejs.org/docs/latest-v12.x/api/http2.html#http2_settings_object

@ZYSzys ZYSzys closed this as completed in f0bee9b Oct 5, 2019
BridgeAR pushed a commit that referenced this issue Oct 9, 2019
@ZYSzys @BridgeAR
http2: set default maxConcurrentStreams
3f15378 
Set the default maxConcurrentStreams to
NGHTTP2_DEFAULT_MAX_CONCURRENT_STREAMS.

PR-URL: #29833
Fixes: #29763
Refs: nghttp2/nghttp2@16c4611
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: David Carlier <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

http2: set stricter default maxConcurrentStreams zys-contrib/node
3 participants
@Trott @trivikr @szmarczak