Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests do not test ./configure --ninja #29415

Closed
cclauss opened this issue Sep 3, 2019 · 4 comments
Closed

Tests do not test ./configure --ninja #29415

cclauss opened this issue Sep 3, 2019 · 4 comments
Labels
python PRs and issues that require attention from people who are familiar with Python. test Issues and PRs related to the tests.

Comments

@cclauss
Copy link
Contributor

cclauss commented Sep 3, 2019 •
edited
Loading

**Is your feature request related to a problem? Please describe.
Neither our Travis nor Jenkins tests seem to cover ./configure --ninja

Describe the solution you'd like
Please describe the desired behavior.

Describe alternatives you've considered
Please describe alternative solutions or features you have considered.
@sam-github
Copy link
Contributor

See: #29371 (comment)

@sam-github sam-github added the test Issues and PRs related to the tests. label Sep 3, 2019
@cclauss cclauss mentioned this issue Sep 3, 2019
Closed
63 tasks
@cclauss cclauss added python PRs and issues that require attention from people who are familiar with Python. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. labels Sep 6, 2019
@cclauss cclauss mentioned this issue Sep 11, 2019
Closed
@sam-github sam-github mentioned this issue Sep 13, 2019
Closed
@cclauss cclauss mentioned this issue Sep 13, 2019
Closed
@patrickhousley patrickhousley mentioned this issue Oct 18, 2019
Closed
3 tasks
patrickhousley added a commit to patrickhousley/node that referenced this issue Oct 25, 2019
@patrickhousley
test: test configure ninja
08b5e13 
- Updated the tooltest target to run unittest module
- Renamed test/tools/test-js2c.py to be discoverable by unittest module
- Added test class for `configure` shell script
- Added a test to ensure `configure` script exits with status code zero
when passed the `--ninja` flag

Closes nodejs#29415
@gengjiawen
Copy link
Member

Should be resolved by #30057

@gengjiawen gengjiawen removed the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Nov 4, 2019
@Trott Trott closed this as completed in 85dd9e8 Nov 6, 2019
@addaleax
Copy link
Member

addaleax commented Nov 6, 2019

I’ll re-open this because #30033 needs to be reverted.

@addaleax addaleax reopened this Nov 6, 2019
MylesBorins pushed a commit that referenced this issue Nov 17, 2019
@patrickhousley @MylesBorins
test: test configure ninja
0dedecc 
- Updated the tooltest target to run unittest module
- Renamed test/tools/test-js2c.py to be discoverable by unittest module
- Added test class for `configure` shell script
- Added a test to ensure `configure` script exits with status code zero
when passed the `--ninja` flag

Closes: #29415

PR-URL: #30033
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Christian Clauss <[email protected]>
@targos
Copy link
Member

targos commented May 7, 2023

The daily workflow uses --ninja.

@targos targos closed this as completed May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
python PRs and issues that require attention from people who are familiar with Python. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: adding test for configure ninja patrickhousley/node
6 participants
@sam-github @Trott @addaleax @targos @cclauss @gengjiawen