stream: internal vs external API and streamlike compat

[ronag]

Try to avoid using internal stream state. Make properties that are used externally part of stream public API. Also improve combat with streamlike objects.

• use writabledFinished (stream: eos use writableFinished when available #28749)
• writableEnded (stream: writableEnded #28934)
• readableEnded (stream: readableEnded #28814)
• writableCorked (stream: writableCorked #29012)
• always invoke end callback (stream: always invoke end callback #28687)
• internal errorEmitted (stream: ensure errorEmitted is always set #28709)
• writableError
• readableError

[ronag]

@mcollina are you +1 on exposing writableCorked. Would be useful in user land for scenarios like:

if (!writable.writableCorked) {
  // Don't install nextTick if we are already corked. 
  writable.cork()
  process.nextTick(() => {
    writable.uncork()
  })
}

[mcollina]

The cork() API is designed so you can avoid that pattern, as cork() can be called multiple times. However, I’m +1 on adding this API.

[ronag]

The cork() API is designed so you can avoid that pattern, as cork() can be called multiple times.

It's more about avoiding creating unnecessary nextTick. We have this exact case in OutgoingMessage where we use a kIsCorked symbol to achieve the same thing.

[mcollina]

+1 Il giorno mar 6 ago 2019 alle 13:34 Robert Nagy <[email protected]> ha scritto:

…

The cork() API is designed so you can avoid that pattern, as cork() can be called multiple times. It's more about avoiding creating unnecessary nextTick. We have this exact case in OutgoingMessage where we use a ´kIsCorked` symbol to achieve the same thing. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29006?email_source=notifications&email_token=AAAMXY4CUVPX52WJAKFWF2DQDFOTPA5CNFSM4IJU5RD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3U2ZNQ#issuecomment-518630582>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAMXY7K3BUV3M6TI7MUNH3QDFOTPANCNFSM4IJU5RDQ> .

[ronag]

this is pretty much done