-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-process-env-tz fails #27856
Comments
That's no surprise. v11.13.0 doesn't have the necessary changes, they only just landed in master. |
I'm sorry, I just tried to prepare for Node Code & Learn Saint Petersburg session. Manual said keep an eye that all tests passed. It's not. What is correct way to run tests against master branch? |
Correct way is to |
Thanks. Will do and let you know if smth goes wrong |
The test is still failing on a fresh master branch on my machine when I do |
@kefir100 If you’re still around for the Code & Learn, could you reach out to one of the mentors and make sure nothing weird is happening? |
Hmm, I got the same exactly same error, after running: # working dir is cloned git repo on master branch
git pull
./configure
make -j9
make test |
@lal12 Can you open a new issue? I assume that's with a clean checkout, no local changes? |
This has happened for two persons on the C&L event in St. Petersburg. The original description mentioned v11.3.0 which was by mistake. The executed code was actually the current master (I updated the description above). They both had a clean clone and just ran |
I looked a bit more into it. The string is built in deps/v8/src/builtins/builtins-date.cc:184, it retrieves the time zone from the internal time zone cache. Depending on the build options it chooses different Implementations either (if INTL is activated) the ICU one, else an OS dependent one (for Linux this e.g. is the POSIX one via So the problem is ICU related (see deps/v8/src/objects/intl-objects.cc:1758). As the documentation of |
I had a look and I think the problem here is that V8 calls the version of
The easy fix is to set |
Set the locale to a known good value because it affects ICU's date string formatting. Setting LC_ALL needs to happen before the first call to `icu::Locale::getDefault()` because ICU caches the result. Fixes: nodejs#27856
current master
Darwin iMac-Mikhail 17.7.0 Darwin Kernel Version 17.7.0: Wed Apr 24 21:17:24 PDT 2019; root:xnu-4570.71.45~1/RELEASE_X86_64 x86_64
I'm running standard test suite using
make test-only
and gotMy best guess here that it happens because I'm using Russian locale at my mac.
The text was updated successfully, but these errors were encountered: